From badbbecfc395e10c307b56fd6332e54386f1d646 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Thu, 13 Jul 2023 17:34:37 -0400 Subject: [PATCH 1/4] Set max-height to effectively 192px --- packages/block-editor/src/components/link-control/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/link-control/style.scss b/packages/block-editor/src/components/link-control/style.scss index 7b6470df435437..bb490e91634219 100644 --- a/packages/block-editor/src/components/link-control/style.scss +++ b/packages/block-editor/src/components/link-control/style.scss @@ -125,7 +125,7 @@ $block-editor-link-control-number-of-actions: 1; .block-editor-link-control__search-results { margin-top: -$grid-unit-20; padding: $grid-unit-10; - max-height: 200px; + max-height: $grid-unit * 24; overflow-y: auto; // allow results list to scroll &.is-loading { From 6464474c96ce35806e632cea367e4fd55df929f1 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Fri, 14 Jul 2023 12:13:13 -0400 Subject: [PATCH 2/4] Add comment for grid unit 24 --- packages/block-editor/src/components/link-control/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/link-control/style.scss b/packages/block-editor/src/components/link-control/style.scss index bb490e91634219..280f7acb0f3cbc 100644 --- a/packages/block-editor/src/components/link-control/style.scss +++ b/packages/block-editor/src/components/link-control/style.scss @@ -125,7 +125,7 @@ $block-editor-link-control-number-of-actions: 1; .block-editor-link-control__search-results { margin-top: -$grid-unit-20; padding: $grid-unit-10; - max-height: $grid-unit * 24; + max-height: $grid-unit * 24; // resolves to 194px overflow-y: auto; // allow results list to scroll &.is-loading { From 6a117b1c7c5f00f1e79ea229b5285cbb60cdea54 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Wed, 7 Feb 2024 08:10:37 -0500 Subject: [PATCH 3/4] adjust margin bottom --- packages/block-editor/src/components/link-control/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/link-control/style.scss b/packages/block-editor/src/components/link-control/style.scss index 280f7acb0f3cbc..671c3c8719d759 100644 --- a/packages/block-editor/src/components/link-control/style.scss +++ b/packages/block-editor/src/components/link-control/style.scss @@ -40,7 +40,7 @@ $block-editor-link-control-number-of-actions: 1; // Provides positioning context for reset button. Without this then when an // error notice is displayed the input's reset button is incorrectly positioned. .block-editor-link-control__search-input-wrapper { - margin-bottom: $grid-unit-10; + margin-bottom: $grid-unit-05; position: relative; } From 0cdae199826f637e7b75dd82ca8338c6e2e39f23 Mon Sep 17 00:00:00 2001 From: Rich Tabor Date: Wed, 7 Feb 2024 09:39:25 -0500 Subject: [PATCH 4/4] try max-height 44 --- packages/block-editor/src/components/link-control/style.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/block-editor/src/components/link-control/style.scss b/packages/block-editor/src/components/link-control/style.scss index 671c3c8719d759..09221bb4d9ac9b 100644 --- a/packages/block-editor/src/components/link-control/style.scss +++ b/packages/block-editor/src/components/link-control/style.scss @@ -138,6 +138,7 @@ $block-editor-link-control-number-of-actions: 1; &.components-button.components-menu-item__button { height: auto; text-align: left; + max-height: $grid-unit * 11; // resolves to 44px } .components-menu-item__item {