From 86a84a90d99a4eb646dba7621d9e3903f3bc395e Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 1 May 2025 15:57:59 +0900 Subject: [PATCH] GitHub Actions: fix components changelog CI check --- .github/workflows/check-components-changelog.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check-components-changelog.yml b/.github/workflows/check-components-changelog.yml index dc29606008accb..7e51425c0be5f6 100644 --- a/.github/workflows/check-components-changelog.yml +++ b/.github/workflows/check-components-changelog.yml @@ -24,7 +24,7 @@ jobs: name: Check CHANGELOG diff runs-on: ubuntu-latest permissions: - contents: read + contents: read steps: - name: 'Get PR commit count' env: @@ -43,13 +43,13 @@ jobs: - name: Check CHANGELOG status env: PR_NUMBER: ${{ github.event.number }} - HEAD_SHA: ${{ github.event.pull_request.head.sha }} + BASE_SHA: ${{ github.event.pull_request.base.sha }} run: | changelog_path="packages/components/CHANGELOG.md" optional_check_notice="This isn't a required check, so if you think your changes are small enough that they don't warrant a CHANGELOG entry, please go ahead and merge without one." # Fail if the PR doesn't touch the changelog - if git diff --quiet "$HEAD_SHA" HEAD -- "$changelog_path"; then + if git diff --quiet "$BASE_SHA" HEAD -- "$changelog_path"; then echo "Please add a CHANGELOG entry to $changelog_path" echo echo "${optional_check_notice}"