From 8630d6911800cc720bade3e7a3742e535f82a998 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 10:26:37 +0900 Subject: [PATCH 1/7] GitHub Actions: Try to fix storybook smoke tests --- .github/workflows/storybook-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index ceed86e1bd469b..42803bd3a5f7f0 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -35,7 +35,7 @@ jobs: run: npm run storybook:build - name: Install Playwright dependencies - run: npx --no playwright install --with-deps + run: npx playwright install chromium --with-deps - name: Serve Storybook and run tests run: | From 7127ab8ab77829cb03a3bf1e6e55239a9187955c Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 11:21:48 +0900 Subject: [PATCH 2/7] Try using locally installed browser --- .github/workflows/storybook-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index 42803bd3a5f7f0..ddd6b95a01ab03 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -43,5 +43,6 @@ jobs: "npx http-server ./storybook/build --port 50240 --silent" \ "npx wait-on tcp:127.0.0.1:50240 && \ NODE_PATH=./node_modules \ + PLAYWRIGHT_BROWSERS_PATH=0 \ npx --package=@storybook/test-runner@0.22.1 -- \ test-storybook --url http://localhost:50240 --config-dir ./storybook" From 1cb5d377742ab77413b83e129612d7a677ad1092 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 15:21:52 +0900 Subject: [PATCH 3/7] Try to match Playwright version --- .github/workflows/storybook-check.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index ddd6b95a01ab03..871a5f63386695 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -34,8 +34,10 @@ jobs: - name: Build Storybook run: npm run storybook:build - - name: Install Playwright dependencies - run: npx playwright install chromium --with-deps + - name: Install test-runner and Playwright dependencies + run: | + npm install --no-save @storybook/test-runner@0.22.1 + npx playwright install chromium --with-deps - name: Serve Storybook and run tests run: | @@ -43,6 +45,4 @@ jobs: "npx http-server ./storybook/build --port 50240 --silent" \ "npx wait-on tcp:127.0.0.1:50240 && \ NODE_PATH=./node_modules \ - PLAYWRIGHT_BROWSERS_PATH=0 \ - npx --package=@storybook/test-runner@0.22.1 -- \ - test-storybook --url http://localhost:50240 --config-dir ./storybook" + npx test-storybook --url http://localhost:50240 --config-dir ./storybook" From 2c1dfe581c31bed5b03e171b095749cf40bc5a02 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 16:38:17 +0900 Subject: [PATCH 4/7] Dummy commit to apply changes to remote repository --- .github/workflows/storybook-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index 871a5f63386695..683d1dc996bf56 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -36,6 +36,7 @@ jobs: - name: Install test-runner and Playwright dependencies run: | + # test npm install --no-save @storybook/test-runner@0.22.1 npx playwright install chromium --with-deps From 6432fb565af4227ae897c6d860ec2cd458f5b233 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 16:38:30 +0900 Subject: [PATCH 5/7] Revert "Dummy commit to apply changes to remote repository" This reverts commit 2c1dfe581c31bed5b03e171b095749cf40bc5a02. --- .github/workflows/storybook-check.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index 683d1dc996bf56..871a5f63386695 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -36,7 +36,6 @@ jobs: - name: Install test-runner and Playwright dependencies run: | - # test npm install --no-save @storybook/test-runner@0.22.1 npx playwright install chromium --with-deps From 0e7c17b220934cc9f6961cab0a93678518cf5dc3 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 17:01:07 +0900 Subject: [PATCH 6/7] Test: remove chromium install --- .github/workflows/storybook-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index 871a5f63386695..945ca2e3984c43 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -37,7 +37,7 @@ jobs: - name: Install test-runner and Playwright dependencies run: | npm install --no-save @storybook/test-runner@0.22.1 - npx playwright install chromium --with-deps + npx playwright install --with-deps - name: Serve Storybook and run tests run: | From f53e482ec83f82be5bc10a93fca0ab37b811fc64 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Thu, 21 Aug 2025 17:19:17 +0900 Subject: [PATCH 7/7] Remove NODE_PATH --- .github/workflows/storybook-check.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/storybook-check.yml b/.github/workflows/storybook-check.yml index 945ca2e3984c43..aa06f847851c68 100644 --- a/.github/workflows/storybook-check.yml +++ b/.github/workflows/storybook-check.yml @@ -44,5 +44,4 @@ jobs: npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ "npx http-server ./storybook/build --port 50240 --silent" \ "npx wait-on tcp:127.0.0.1:50240 && \ - NODE_PATH=./node_modules \ npx test-storybook --url http://localhost:50240 --config-dir ./storybook"