diff --git a/packages/block-library/src/pullquote/editor.scss b/packages/block-library/src/pullquote/editor.scss index b2fc97541bda99..075f2ff5aa56f1 100644 --- a/packages/block-library/src/pullquote/editor.scss +++ b/packages/block-library/src/pullquote/editor.scss @@ -20,8 +20,8 @@ transform: translateX(-50%); } - & > .block-library-pullquote__content .editor-rich-text__tinymce[data-is-empty="true"]::before, - & > .editor-rich-text p { + & blockquote > .block-library-pullquote__content .editor-rich-text__tinymce[data-is-empty="true"]::before, + & blockquote > .editor-rich-text p { font-size: 24px; line-height: 1.6; } diff --git a/packages/block-library/src/pullquote/index.js b/packages/block-library/src/pullquote/index.js index 539308618793df..bd4ac84feb8d81 100644 --- a/packages/block-library/src/pullquote/index.js +++ b/packages/block-library/src/pullquote/index.js @@ -55,33 +55,35 @@ export const settings = { const { value, citation } = attributes; return ( -
-+ ); }, @@ -89,14 +91,29 @@ export const settings = { const { value, citation } = attributes; return ( -setAttributes( { - value: fromRichTextValue( nextValue ), - } ) - } - /* translators: the text of the quotation */ - placeholder={ __( 'Write quote…' ) } - wrapperClassName="block-library-pullquote__content" - /> - { ( ! RichText.isEmpty( citation ) || isSelected ) && ( + + + { ( ! RichText.isEmpty( citation ) || isSelected ) && ( +setAttributes( { - citation: nextCitation, + ( nextValue ) => setAttributes( { + value: fromRichTextValue( nextValue ), } ) } - className="wp-block-pullquote__citation" + /* translators: the text of the quotation */ + placeholder={ __( 'Write quote…' ) } + wrapperClassName="block-library-pullquote__content" /> - ) } - setAttributes( { + citation: nextCitation, + } ) + } + className="wp-block-pullquote__citation" + /> + ) } +
-+- { ! RichText.isEmpty( citation ) && } -
+++ { ! RichText.isEmpty( citation ) && } +
++ ); + }, + }, { attributes: { ...blockAttributes, citation: { diff --git a/packages/block-library/src/pullquote/style.scss b/packages/block-library/src/pullquote/style.scss index 2467adff4e5437..7bc4b66cdc4408 100644 --- a/packages/block-library/src/pullquote/style.scss +++ b/packages/block-library/src/pullquote/style.scss @@ -4,14 +4,14 @@ &.alignleft, &.alignright { - max-width: 400px; + max-width: $content-width / 2; - > p { + p { font-size: 20px; } } - > p { + p { font-size: 24px; line-height: 1.6; } diff --git a/packages/block-library/src/pullquote/test/__snapshots__/index.js.snap b/packages/block-library/src/pullquote/test/__snapshots__/index.js.snap index 0fb96fbe630617..4a96bb5863af57 100644 --- a/packages/block-library/src/pullquote/test/__snapshots__/index.js.snap +++ b/packages/block-library/src/pullquote/test/__snapshots__/index.js.snap @@ -1,37 +1,39 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`core/pullquote block edit matches snapshot 1`] = ` -+ { ! RichText.isEmpty( citation ) && } +
--+++ + `; diff --git a/test/integration/full-content/fixtures/core__pullquote.html b/test/integration/full-content/fixtures/core__pullquote.html index 8c13cedfe000dc..87bd8b74f964c6 100644 --- a/test/integration/full-content/fixtures/core__pullquote.html +++ b/test/integration/full-content/fixtures/core__pullquote.html @@ -1,5 +1,7 @@ ----+--- Write quote… -
+ +++ Write quote… +
+-+Testing pullquote block...
...with a caption -+ diff --git a/test/integration/full-content/fixtures/core__pullquote.json b/test/integration/full-content/fixtures/core__pullquote.json index 11d576614228cd..a288af83867dad 100644 --- a/test/integration/full-content/fixtures/core__pullquote.json +++ b/test/integration/full-content/fixtures/core__pullquote.json @@ -21,6 +21,6 @@ ] }, "innerBlocks": [], - "originalContent": "++Testing pullquote block...
...with a caption +\n" + "originalContent": "Testing pullquote block...
...with a caption\n\n " } ] diff --git a/test/integration/full-content/fixtures/core__pullquote.parsed.json b/test/integration/full-content/fixtures/core__pullquote.parsed.json index c8d7f7c3c2dd61..bafaa101c2d0ae 100644 --- a/test/integration/full-content/fixtures/core__pullquote.parsed.json +++ b/test/integration/full-content/fixtures/core__pullquote.parsed.json @@ -3,7 +3,7 @@ "blockName": "core/pullquote", "attrs": null, "innerBlocks": [], - "innerHTML": "\n\n\nTesting pullquote block...
...with a caption\n\n\n" + "innerHTML": "\nTesting pullquote block...
...with a caption\n\n \n" }, { "attrs": {}, diff --git a/test/integration/full-content/fixtures/core__pullquote.serialized.html b/test/integration/full-content/fixtures/core__pullquote.serialized.html index 00f47cf0d5e399..6ef3209575aeba 100644 --- a/test/integration/full-content/fixtures/core__pullquote.serialized.html +++ b/test/integration/full-content/fixtures/core__pullquote.serialized.html @@ -1,3 +1,3 @@ -\n\nTesting pullquote block...
...with a caption\n+Testing pullquote block...
...with a captiondiff --git a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.html b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.html index 252b029f1f888d..eace115333c624 100644 --- a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.html +++ b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.html @@ -1,7 +1,9 @@ - Testing pullquote block...
...with a caption-+Paragraph one
-Paragraph two
- by whomever -+ diff --git a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.json b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.json index 266568fa51bc00..c889d363b653ca 100644 --- a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.json +++ b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.json @@ -39,6 +39,6 @@ ] }, "innerBlocks": [], - "originalContent": "++Paragraph one
+Paragraph two
+ by whomever +\n" + "originalContent": "Paragraph one
\nParagraph two
\n by whomever\n\n " } ] diff --git a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.parsed.json b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.parsed.json index 2a816764b3ae4d..ee9cee5764b70f 100644 --- a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.parsed.json +++ b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.parsed.json @@ -3,7 +3,7 @@ "blockName": "core/pullquote", "attrs": null, "innerBlocks": [], - "innerHTML": "\n\n\nParagraph one
\nParagraph two
\n by whomever\n\t\n\n" + "innerHTML": "\nParagraph one
\nParagraph two
\n by whomever\n\n \n" }, { "attrs": {}, diff --git a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.serialized.html b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.serialized.html index 635df56edcf4f7..333b051f197287 100644 --- a/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.serialized.html +++ b/test/integration/full-content/fixtures/core__pullquote__multi-paragraph.serialized.html @@ -1,3 +1,3 @@ -\n\nParagraph one
\nParagraph two
\n by whomever\n\t+Paragraph one
Paragraph two
by whomeverParagraph one
Paragraph two
by whomever