Rename WP_Theme::is_block_based to wp_is_block_theme.

See https://core.trac.wordpress.org/ticket/54552

Author: anton-vlasenko

src/wp-admin/includes/dashboard.php

@@ -1993,11 +1993,11 @@ function wp_welcome_panel() {
 	$customize_url          = null;
 	$can_edit_theme_options = current_user_can( 'edit_theme_options' );
 	$can_customize          = current_user_can( 'customize' );
-	$is_block_based_theme   = wp_is_block_theme();
+	$is_block_theme         = wp_is_block_theme();
 
-	if ( $is_block_based_theme && $can_edit_theme_options ) {
+	if ( $is_block_theme && $can_edit_theme_options ) {
 		$customize_url = esc_url( admin_url( 'site-editor.php' ) );
-	} elseif ( ! $is_block_based_theme && $can_customize ) {
+	} elseif ( ! $is_block_theme && $can_customize ) {
 		$customize_url = wp_customize_url();
 	}
 	?>
@@ -2012,7 +2012,7 @@ function wp_welcome_panel() {
 		<?php endif; ?>
 		<a class="button button-primary button-hero hide-if-customize" href="<?php echo esc_url( admin_url( 'themes.php' ) ); ?>"><?php _e( 'Customize Your Site' ); ?></a>
 		<?php if ( current_user_can( 'install_themes' ) || ( current_user_can( 'switch_themes' ) && count( wp_get_themes( array( 'allowed' => true ) ) ) > 1 ) ) : ?>
-			<?php $themes_link = $can_customize && ! $is_block_based_theme ? add_query_arg( 'autofocus[panel]', 'themes', admin_url( 'customize.php' ) ) : admin_url( 'themes.php' ); ?>
+			<?php $themes_link = $can_customize && ! $is_block_theme ? add_query_arg( 'autofocus[panel]', 'themes', admin_url( 'customize.php' ) ) : admin_url( 'themes.php' ); ?>
 			<p class="hide-if-no-customize">
 				<?php
 					/* translators: %s: URL to Themes panel in Customizer or Themes screen. */

src/wp-admin/includes/theme.php

@@ -704,11 +704,11 @@ function wp_prepare_themes_for_js( $themes = null ) {
 
 		$can_edit_theme_options = current_user_can( 'edit_theme_options' );
 		$can_customize          = current_user_can( 'customize' );
-		$is_block_based_theme   = $theme->is_block_based();
+		$is_block_theme         = $theme->is_block_theme();
 
-		if ( $is_block_based_theme && $can_edit_theme_options ) {
+		if ( $is_block_theme && $can_edit_theme_options ) {
 			$customize_action = esc_url( admin_url( 'site-editor.php' ) );
-		} elseif ( ! $is_block_based_theme && $can_customize && $can_edit_theme_options ) {
+		} elseif ( ! $is_block_theme && $can_customize && $can_edit_theme_options ) {
 			$customize_action = esc_url(
 				add_query_arg(
 					array(

src/wp-includes/class-wp-theme.php

@@ -1467,7 +1467,7 @@ public function is_allowed( $check = 'both', $blog_id = null ) {
 	 *
 	 * @return bool
 	 */
-	public function is_block_based() {
+	public function is_block_theme() {
 		$paths_to_index_block_template = array(
 			$this->get_file_path( '/block-templates/index.html' ),
 			$this->get_file_path( '/templates/index.html' ),

tests/phpunit/tests/theme/wpTheme.php

@@ -248,17 +248,17 @@ public function test_network_disable_multiple_themes() {
 	}
 
 	/**
-	 * @dataProvider data_is_block_based
+	 * @dataProvider data_is_block_theme
 	 * @ticket 54460
 	 *
-	 * @covers WP_Theme::is_block_based
+	 * @covers WP_Theme::is_block_theme
 	 *
 	 * @param string $theme_dir Directory of the theme to test.
 	 * @param bool   $expected  Expected result.
 	 */
-	public function test_is_block_based( $theme_dir, $expected ) {
+	public function test_is_block_theme( $theme_dir, $expected ) {
 		$theme  = new WP_Theme( $theme_dir, $this->theme_root );
-		$actual = $theme->is_block_based();
+		$actual = $theme->is_block_theme();
 
 		if ( $expected ) {
 			$this->assertTrue( $actual );
@@ -272,7 +272,7 @@ public function test_is_block_based( $theme_dir, $expected ) {
 	 *
 	 * @return array
 	 */
-	public function data_is_block_based() {
+	public function data_is_block_theme() {
 		return array(
 			'default - non-block theme' => array(
 				'theme_dir' => 'default',