Skip to content

Commit 1bf9367

Browse files
JasonEtcoamulyarajamaya-rossmegbird
authored
Add release notes for GHES 3.0.0.rc2 (github#17547)
* Add 0-rc2 * Started adding release notes * added more line items * finished initial draft of enterprise 2 fix notes * some more line items added * updated known issues and took out rc1 fixes * added download link bug fix * added new known issues identified in rc2 * Fix a typo * Lint YAML * Tweak sorting for new version schem * Use today's date * removed links to PRs and reduced notes to most important ones * Fix indentation * bug_fixes => bugs * spruce it up * typo * update without changes Co-authored-by: Amulya Raja <[email protected]> Co-authored-by: Maya <[email protected]> Co-authored-by: Meg Bird <[email protected]>
1 parent 653a57a commit 1bf9367

File tree

3 files changed

+26
-4
lines changed

3 files changed

+26
-4
lines changed

data/release-notes/3-0/0-rc1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
date: '2021-01-12'
22
release_candidate: true
3-
intro: Release notes are now published on the documentation site. The new location makes it easier to learn about new releases and features at the same time. Historical release notes are available on [GitHub Enterprise Releases](https://enterprise.github.com/releases).
3+
intro: Release candidate versions should be tested on non-production environments. For more information about the Release Candidate Program, see the [GitHub Blog](https://github.blog/2020-12-03-improving-the-ghes-release-process-release-candidates/) or "[About upgrades to new releases](/admin/overview/about-upgrades-to-new-releases)".
44
sections:
55
features:
66
- heading: GitHub Actions

data/release-notes/3-0/0-rc2.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
date: '2021-01-29'
2+
release_candidate: true
3+
intro: Release candidate versions should be tested on non-production environments. For more information about the Release Candidate Program, see the [GitHub Blog](https://github.blog/2020-12-03-improving-the-ghes-release-process-release-candidates/) or "[About upgrades to new releases](/admin/overview/about-upgrades-to-new-releases)."
4+
sections:
5+
bugs:
6+
- heading: Fixes for known issues from Release Candidate 1
7+
notes:
8+
- If you disabled GitHub Actions following an unsuccessful attempt to set up GitHub Actions, then you will not be able to create the first user and use the appliance.
9+
- The "Mandatory message viewed" audit log event was not being saved.
10+
- '`ghe-config-apply` needed to run on a replica during an initial setup before `ghe-repl-setup` could run to start replication.'
11+
- Removing yourself as an enterprise owner returned a 404.
12+
- heading: Fixes for other issues
13+
notes:
14+
- Issues with migrations and upgrades to 3.0.0 have been fixed.
15+
- Backup Utilities versioning now works for release candidate versions.
16+
- Generating a support bundle resulted in an error in the orchestrator logs.
17+
- A large restore could result in Redis running out of memory.
18+
- The checkbox to enable GitHub Actions in the Management Console is now visible with any authentication method.
19+
- GitHub Actions can only be enabled if the required storage is also configured.
20+
- '`ghe-repl-status` could silently fail if MSSQL replication is not configured.'
21+
22+
known_issues:
23+
- The known issues for Release Candidate 1 still apply, excluding the bug fixes listed.

middleware/contextualizers/enterprise-release-notes.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const semver = require('semver')
21
const renderContent = require('../../lib/render-content')
32
const patterns = require('../../lib/patterns')
43
const enterpriseReleases = require('../../lib/enterprise-server-releases').supported
@@ -20,8 +19,8 @@ function sortPatchKeys (release, version) {
2019
})
2120
return keys
2221
.sort((a, b) => {
23-
if (semver.gt(a.version, b.version)) return -1
24-
if (semver.lt(a.version, b.version)) return 1
22+
if (a.version > b.version) return -1
23+
if (a.version < b.version) return 1
2524
return 0
2625
})
2726
}

0 commit comments

Comments
 (0)