Skip to content

Commit eed1b87

Browse files
pcostantiniStevenic
authored andcommitted
remove 'trigger(...)' wrap from addDialogTrigger (microsoft#2797)
1 parent 490c5a1 commit eed1b87

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

Node/core/lib/dialogs/ActionSet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var ActionSet = (function () {
1818
ActionSet.prototype.addDialogTrigger = function (actions, dialogId) {
1919
if (this.trigger) {
2020
this.trigger.localizationNamespace = dialogId.split(':')[0];
21-
actions.beginDialogAction('trigger(' + dialogId + ')', dialogId, this.trigger);
21+
actions.beginDialogAction(dialogId, dialogId, this.trigger);
2222
}
2323
};
2424
ActionSet.prototype.findActionRoutes = function (context, callback) {

Node/core/src/dialogs/ActionSet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export class ActionSet {
9191
public addDialogTrigger(actions: ActionSet, dialogId: string): void {
9292
if (this.trigger) {
9393
this.trigger.localizationNamespace = dialogId.split(':')[0];
94-
actions.beginDialogAction('trigger(' + dialogId + ')', dialogId, this.trigger);
94+
actions.beginDialogAction(dialogId, dialogId, this.trigger);
9595
}
9696
}
9797

Node/core/tests/actions.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ describe('actions', function() {
6464
onSelectAction: function (session, args, next) {
6565
assert(session !== null);
6666
assert(args !== null);
67+
assert(args.action === '/');
6768
assert(next !== null);
6869
done();
6970
}

0 commit comments

Comments
 (0)