replaced mutable default values with None

Signed-off-by: AutomatedTester <[email protected]>

Author: nicolasunravel

.gitignore

@@ -6,3 +6,4 @@ build/
 *.egg-info/
 .cache/
 bmp.log
+.idea/

browsermobproxy/client.py

@@ -1,14 +1,14 @@
 import requests
 
 try:
-  from urllib.parse import urlencode, unquote
+    from urllib.parse import urlencode, unquote
 except ImportError:
-  from urllib import urlencode, unquote
+    from urllib import urlencode, unquote
 import json
 
 
 class Client(object):
-    def __init__(self, url, params={}, options={}):
+    def __init__(self, url, params=None, options=None):
         """
         Initialises a new Client object
 
@@ -18,6 +18,8 @@ def __init__(self, url, params={}, options={}):
         :param options: Dictionary that can contain the port of an existing
                         proxy to use (for example 'existing_proxy_port_to_use')
         """
+        params = params if params is not None else {}
+        options = options if options is not None else {}
         self.host = "http://" + url
         if params:
             urlparams = "?" + unquote(urlencode(params))
@@ -97,7 +99,7 @@ def har(self):
         return r.json()
 
 
-    def new_har(self, ref=None, options={}):
+    def new_har(self, ref=None, options=None):
         """
         This sets a new HAR to be recorded
 
@@ -109,6 +111,8 @@ def new_har(self, ref=None, options={}):
                    captureContent - Boolean, capture content bodies \
                    captureBinaryContent - Boolean, capture binary content
         """
+        options = options if options is not None else {}
+
         if ref:
             payload = {"initialPageRef": ref}
         else:
@@ -281,15 +285,15 @@ def timeouts(self, options):
                          params)
         return r.status_code
 
-    def remap_hosts(self, address=None, ip_address=None, hostmap={}):
+    def remap_hosts(self, address=None, ip_address=None, hostmap=None):
         """
         Remap the hosts for a specific URL
 
         :param address: url that you wish to remap
         :param ip_address: IP Address that will handle all traffic for the address passed in
         :param **hostmap: Other hosts to be added as keyword arguments
         """
-
+        hostmap = hostmap if hostmap is not None else {}
         if (address is not None and ip_address is not None):
             hostmap[address] = ip_address
 

browsermobproxy/server.py

@@ -27,13 +27,14 @@ def url(self):
         """
         return "http://%s:%d" % (self.host, self.port)
 
-    def create_proxy(self, params={}):
+    def create_proxy(self, params=None):
         """
         Gets a client class that allow to set all the proxy details that you
         may need to.
         :param params: Dictionary where you can specify params \
                     like httpProxy and httpsProxy
         """
+        params = params if params is not None else {}
         client = Client(self.url[7:], params)
         return client
 
@@ -50,7 +51,7 @@ def _is_listening(self):
 
 class Server(RemoteServer):
 
-    def __init__(self, path='browsermob-proxy', options={}):
+    def __init__(self, path='browsermob-proxy', options=None):
         """
         Initialises a Server object
 
@@ -59,6 +60,8 @@ def __init__(self, path='browsermob-proxy', options={}):
                      More items will be added in the future. \
                      This defaults to an empty dictionary
         """
+        options = options if options is not None else {}
+
         path_var_sep = ':'
         if platform.system() == 'Windows':
             path_var_sep = ';'

browsermobproxy/webdriver_event_listener.py

@@ -2,7 +2,8 @@
 
 class WebDriverEventListener(AbstractEventListener):
 
-    def __init__(self, client, refs={}):
+    def __init__(self, client, refs=None):
+        refs = refs if refs is not None else {}
         self.client = client
         self.hars = []
         self.refs = refs