Skip to content

Commit d4701af

Browse files
committed
Switch to http.absolute_uri
1 parent 074fd0b commit d4701af

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

src/sentry/api/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from sentry.app import raven, tsdb
2020
from sentry.models import ApiKey, AuditLogEntry
2121
from sentry.utils.cursors import Cursor
22-
from sentry.utils.http import is_valid_origin
22+
from sentry.utils.http import absolute_uri, is_valid_origin
2323

2424
from .authentication import ApiKeyAuthentication, ProjectKeyAuthentication
2525
from .paginator import Paginator
@@ -60,7 +60,7 @@ def build_cursor_link(self, request, name, cursor):
6060
for k, v in request.GET.iteritems()
6161
if k != 'cursor'
6262
)
63-
base_url = request.build_absolute_uri(request.path)
63+
base_url = absolute_uri(request.path)
6464
if querystring:
6565
base_url = '{0}?{1}'.format(base_url, querystring)
6666
else:

src/sentry/auth/helper.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
OrganizationMember, OrganizationMemberTeam, User
1919
)
2020
from sentry.utils.auth import get_login_redirect
21+
from sentry.utils.http import absolute_uri
2122
from sentry.web.helpers import render_to_response
2223

2324
from . import manager
@@ -136,7 +137,7 @@ def init_pipeline(self):
136137
self.request.session.modified = True
137138

138139
def get_redirect_url(self):
139-
return self.request.build_absolute_uri(reverse('sentry-auth-sso'))
140+
return absolute_uri(reverse('sentry-auth-sso'))
140141

141142
def clear_session(self):
142143
if 'auth' in self.request.session:

src/sentry/middleware/locale.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@
1515

1616
from sentry.app import env
1717
from sentry.models import UserOption
18+
from sentry.utils.http import absolute_uri
1819
from sentry.utils.safe import safe_execute
1920

2021

2122
class SentryLocaleMiddleware(object):
2223
def process_request(self, request):
2324
# HACK: bootstrap some env crud if we haven't yet
2425
if not settings.SENTRY_URL_PREFIX:
25-
settings.SENTRY_URL_PREFIX = request.build_absolute_uri(reverse('sentry')).strip('/')
26+
settings.SENTRY_URL_PREFIX = absolute_uri(reverse('sentry')).strip('/')
2627

2728
# bind request to env
2829
env.request = request

src/sentry/web/api.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@
5252
from sentry.utils.data_scrubber import SensitiveDataFilter
5353
from sentry.utils.db import get_db_engine
5454
from sentry.utils.javascript import to_json
55-
from sentry.utils.http import is_valid_origin, get_origins, is_same_domain
55+
from sentry.utils.http import (
56+
absolute_uri, is_valid_origin, get_origins, is_same_domain
57+
)
5658
from sentry.utils.safe import safe_execute
5759
from sentry.web.decorators import has_access
5860
from sentry.web.frontend.groups import _get_group_list
@@ -418,7 +420,7 @@ def poll(request, organization, project):
418420
for k, v in request.GET.iteritems()
419421
if k != 'cursor'
420422
)
421-
base_url = request.build_absolute_uri(request.path)
423+
base_url = absolute_uri(request.path)
422424
if querystring:
423425
base_url = '{0}?{1}'.format(base_url, querystring)
424426
else:

0 commit comments

Comments
 (0)