Windows: Refactor DLL creation on Cygwin/MinGW env #128
Conversation
This patch removes conditional type for os.setf(), which was failing on msys2 llvm environment and replaces it by auto type. Signed-off-by: Jerome Haxhiaj <[email protected]>
|
This pull-requests depends on #127 |
Windows DLLs can't contain unresolved symbols. Therefore systemc, when built with MSYS2, is split in two libraries: libsystemc-<version>.dll without unresolved symbols and libsystemc.a with unresolved symbols. Currently, cmake target systemc (exposing libsystemc.a) is aliased as SystemC::systemc This leads to a situation where projects that depend SystemC::systemc would link only against the systemc.a and drop the dll. This commit introduces the interface target library `systemc_if`, which links against systemc dll and static and is aliased as SystemC::systemc. To insure backward compatiblity, this mechanism is enabled only when systemc is built as a shared library This commits reworks the sections that merges libsystemc.a and libsystemc-<version>.dll.a
jeromehaxhiaj-qti
force-pushed
the
windows_on_arm64_ci
branch
from
42cb9d0 to
036b9e3
Compare
jeromehaxhiaj-qti
changed the title
|
Tested SystemC DLL creation and usage successfully on Win11, using CMake 3.31.1 and MSVC compiler 16.11 ("Visual Studio 16 2019"). My recommendation is to merge |
maehne
left a comment
maehne
left a comment
There was a problem hiding this comment.
The proposed changes make sense to me. However, is the generated library name really libsystemc-.dll on your platform? According to the CMakeLists.txt, the dash should be followed by the SystemC language version extracted from sc_ver.h.
IMHO, the changes to sc_signed.cpp and sc_unsigned.cpp are not topical, but a welcome clean up.
|
Hi @maehne |
|
I confirm the name of the generated DLL is correct: |
4 participants
Windows DLLs can't contain unresolved symbols. Therefore systemc,
when built with MSYS2, is split in two libraries: libsystemc-.dll
without unresolved symbols and libsystemc.a with unresolved symbols.
Currently, cmake target systemc (exposing libsystemc.a) is aliased as SystemC::systemc
This leads to a situation where projects that depend SystemC::systemc
would link only against the systemc.a and drop the dll.
This commit introduces the interface target library
systemc_if,which links against systemc dll and static and is aliased as SystemC::systemc.
To insure backward compatiblity, this mechanism is enabled only
when systemc is built as a shared library
This commits reworks the sections that merges
libsystemc.a and libsystemc-VER.dll.a