Skip to content

feat(outputs): app-slug and installation-id #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 1, 2024
Merged

feat(outputs): app-slug and installation-id #105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a171f04
feat: add GitHub App's slug (`app-slug`) output
maboloshi Feb 18, 2024
0790d66
Merge branch 'main' into main
maboloshi Feb 22, 2024
a22f5cf
Update snapshot files
maboloshi Feb 22, 2024
36eed15
feat: add GitHub App's installation Id output
maboloshi Feb 22, 2024
c0eb2f6
Update snapshot files（Resolved Line Break Styles）
maboloshi Feb 22, 2024
2903743
Apply suggestions from code review
parkerbxyz Mar 1, 2024
920b22e
Merge branch 'main' into main
parkerbxyz Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@parkerbxyz
parkerbxyz authored Mar 1, 2024
commit 290374300eba0974142053d2dd81cb2ae19cded8
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,11 @@ GitHub App installation access token.

### `installation-id`

GitHub App's installation Id.
GitHub App installation ID.

### `app-slug`

GitHub App's slug.
GitHub App slug.

## How it works

Expand Down
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ outputs:
token:
description: "GitHub installation access token"
installation-id:
description: "GitHub App's installation Id"
description: "GitHub App installation ID"
app-slug:
description: "GitHub App's slug"
description: "GitHub App slug"
runs:
using: "node20"
main: "dist/main.cjs"
Expand Down
2 changes: 1 addition & 1 deletion tests/main-token-get-owner-set-to-user-fail-response.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ await test((mockPool) => {
process.env.INPUT_OWNER = "smockle";
delete process.env.INPUT_REPOSITORIES;

// Mock installation id and app slug request
// Mock installation ID and app slug request
const mockInstallationId = "123456";
const mockAppSlug = "github-actions";
mockPool
Expand Down
2 changes: 1 addition & 1 deletion tests/main-token-get-owner-set-to-user-repo-unset.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ await test((mockPool) => {
process.env.INPUT_OWNER = "smockle";
delete process.env.INPUT_REPOSITORIES;

// Mock installation id and app slug request
// Mock installation ID and app slug request
const mockInstallationId = "123456";
const mockAppSlug = "github-actions";
mockPool
Expand Down
2 changes: 1 addition & 1 deletion tests/main-token-get-owner-unset-repo-unset.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ await test((mockPool) => {
delete process.env.INPUT_OWNER;
delete process.env.INPUT_REPOSITORIES;

// Mock installation id and app slug request
// Mock installation ID and app slug request
const mockInstallationId = "123456";
const mockAppSlug = "github-actions";
mockPool
Expand Down
2 changes: 1 addition & 1 deletion tests/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export async function test(cb = (_mockPool) => {}, env = DEFAULT_ENV) {

// Calling `auth({ type: "app" })` to obtain a JWT doesn’t make network requests, so no need to intercept.

// Mock installation id and app slug request
// Mock installation ID and app slug request
const mockInstallationId = "123456";
const mockAppSlug = "github-actions";
const owner = env.INPUT_OWNER ?? env.GITHUB_REPOSITORY_OWNER;
Expand Down