[ci] Do not use empty exclude directories in analyze_command. (flutter#3748)

* Add CUSTOM_ANALYSIS_PLUGINS back with all the plugins that now have a custom analysis_options.yaml

Author: ditman

script/incremental_build.sh

@@ -19,8 +19,39 @@ ALL_EXCLUDED=("")
 # because we adopted stricter analysis rules recently and needed to exclude
 # already failing packages to start linting the repo as a whole.
 #
-# TODO(mklim): Remove everything from this list. https://github.com/flutter/flutter/issues/45440
+# Finding all: `find packages -name analysis_options.yaml | sort | cut -d/ -f2`
+#
+# TODO(ecosystem): Remove everything from this list. https://github.com/flutter/flutter/issues/76229
 CUSTOM_ANALYSIS_PLUGINS=(
+  android_alarm_manager
+  android_intent
+  battery
+  camera
+  connectivity
+  cross_file
+  device_info
+  e2e
+  espresso
+  file_selector
+  flutter_plugin_android_lifecycle
+  google_maps_flutter
+  google_sign_in
+  image_picker
+  in_app_purchase
+  integration_test
+  ios_platform_images
+  local_auth
+  package_info
+  path_provider
+  plugin_platform_interface
+  quick_actions
+  sensors
+  share
+  shared_preferences
+  url_launcher
+  video_player
+  webview_flutter
+  wifi_info_flutter
 )
 
 # Comma-separated string of the list above

script/tool/lib/src/analyze_command.dart

@@ -42,10 +42,12 @@ class AnalyzeCommand extends PluginCommand {
         continue;
       }
 
-      final bool whitelisted = argResults[_customAnalysisFlag].any(
+      final bool allowed = argResults[_customAnalysisFlag].any(
           (String directory) =>
+              directory != null &&
+              directory.isNotEmpty &&
               p.isWithin(p.join(packagesDir.path, directory), file.path));
-      if (whitelisted) {
+      if (allowed) {
         continue;
       }
 

script/tool/test/analyze_command_test.dart

@@ -93,5 +93,20 @@ void main() {
                 pluginDir.path),
           ]));
     });
+
+    // See: https://github.com/flutter/flutter/issues/78994
+    test('takes an empty allow list', () async {
+      await createFakePlugin('foo', withExtraFiles: <List<String>>[
+        <String>['analysis_options.yaml']
+      ]);
+
+      final MockProcess mockProcess = MockProcess();
+      mockProcess.exitCodeCompleter.complete(0);
+      processRunner.processToReturn = mockProcess;
+
+      await expectLater(
+          () => runner.run(<String>['analyze', '--custom-analysis', '']),
+          throwsA(const TypeMatcher<ToolExit>()));
+    });
   });
 }