Merge pull request #28 from afrase/fix/out-of-credits-error

Fix error check string to fix #25

Author: afrase

CHANGELOG.md

@@ -0,0 +1,12 @@
+# 0.1.2
+
+* Removed the double quote from the body check since it appears a space is added after the colon.
+* Added changelog file.
+
+# 0.1.1
+
+* Removed safe accessor usage to work with older versions of Ruby.
+
+# 0.1.0
+
+* Added support for V2 of Zerobounce API.

lib/zerobounce/error.rb

@@ -49,7 +49,7 @@ def parse_500(env)
       def parse_200(env)
         # The body hasn't been parsed yet and to avoid potentially parsing the body twice
         # we just use String#start_with?
-        ApiError.new(env) if env[:body].to_s.start_with?('{"error":"')
+        ApiError.new(env) if env[:body].to_s.start_with?('{"error":')
       end
     end
   end

lib/zerobounce/middleware/raise_error.rb

@@ -14,7 +14,7 @@ class RaiseError < Faraday::Response::Middleware
       # @param [Hash] env
       # @raise [Error]
       def on_complete(env)
-        if (error = Zerobounce::Error.from_response(env)) # rubocop:disable GuardClause
+        if (error = Zerobounce::Error.from_response(env)) # rubocop:disable Style/GuardClause
           raise error
         end
       end

lib/zerobounce/version.rb

@@ -2,5 +2,5 @@
 
 module Zerobounce
   # The version of the gem.
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

spec/zerobounce/error_spec.rb

@@ -26,7 +26,8 @@
       end
 
       context 'when body looks like an error' do
-        before { env[:body] = '{"error":"Invalid API Key or your account ran out of credits"}' }
+        # The Zerobounce body contains a space after the `:`
+        before { env[:body] = '{"error": "Invalid API Key or your account ran out of credits"}' }
 
         it 'returns ApiError' do
           expect(described_class.from_response(env)).to be_a(Zerobounce::ApiError)

zerobounce.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'zerobounce/version'
 
-Gem::Specification.new do |spec| # rubocop:disable BlockLength
+Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   spec.name          = 'zerobounce'
   spec.version       = Zerobounce::VERSION
   spec.authors       = ['Aaron Frase']