Use keyring to store passwords

Reference: https://pypi.org/project/keyring

Author: ianding1

README.md

@@ -4,18 +4,27 @@
 
 Solve LeetCode problems in Vim!
 
-**Supported sorting by columns (Hooray🎉🎉🎉) Now you can solve problems by frequency!**
-
 This Vim plugin is inspired by [skygragon/leetcode-cli][leetcode-cli].
 
+**Important Update! Please setup keyring for password safety:**
+
+1. Install keyring with `pip3 install keyring --user`
+2. Remove `g:leetcode_password` from your configuration.
+3. The first time you sign in, **leetcode.vim** will prompt for the password
+and store it in keyring.
+
 ## Installation
 
 1. Vim with `+python3` feature is **required**. Install the **pynvim** package
 for Neovim:
 ```sh
 pip3 install pynvim --user
 ```
-2. Install the plugin:
+2. Install **keyring**:
+```sh
+pip3 install keyring --user
+```
+3. Install the plugin:
 ```vim
 Plug 'ianding1/leetcode.vim'
 ```
@@ -64,7 +73,11 @@ Default value is `''`.
 
 ### `g:leetcode_password`
 
-Set to the LeetCode password for auto login.
+**Deprecated in favor of keyring.** Set to the LeetCode password for auto login.
+
+If you have installed keyring, then just leave this option blank.
+**leetcode.vim** will prompt for the password the first time you sign in, and
+store the password in keyring.
 
 **WARNING: the password is stored in plain text.**
 

autoload/leetcode.vim

@@ -21,15 +21,33 @@ else:
     os.environ['LEETCODE_BASE_URL'] = 'https://leetcode.com'
 
 import leetcode
+
+try:
+    import keyring
+    has_keyring = True
+except ImportError:
+    has_keyring = False
 EOF
 
 let s:inited = py3eval('leetcode.inited')
 
+let s:has_keyring = py3eval('has_keyring')
+
 if g:leetcode_debug
     python3 leetcode.enable_logging()
 endif
 
-function! leetcode#SignIn(ask) abort
+function! s:DoSignIn(username, password) abort
+    let expr = printf('leetcode.signin("%s", "%s")', a:username, a:password)
+    let success = py3eval(expr)
+
+    if success
+        echo 'Signed in as ' . a:username
+    endif
+    return success
+endfunction
+
+function! s:LegacySignIn(ask) abort
     if !s:inited
         return v:false
     endif
@@ -45,13 +63,43 @@ function! leetcode#SignIn(ask) abort
         let password = g:leetcode_password
     endif
 
-    let expr = printf('leetcode.signin("%s", "%s")', username, password)
-    let success = py3eval(expr)
+    return s:DoSignIn(username, password)
+endfunction
 
-    if a:ask && success
-        echo 'succesfully signed in as '.username
+function! s:KeyringSignIn(ask) abort
+    if !s:inited
+        return v:false
+    endif
+
+    if g:leetcode_username != ''
+        let saved_password = py3eval(
+                    \ printf('keyring.get_password("leetcode.vim", "%s")',
+                    \ g:leetcode_username))
+    else
+        let saved_password = v:null
+    endif
+
+    if a:ask || saved_password == v:null
+        let username = input('Username: ', g:leetcode_username)
+        let password = inputsecret('Password: ')
+        let g:leetcode_username = username
+        call py3eval(printf('keyring.set_password("leetcode.vim", "%s", "%s")',
+                    \ username, password))
+        redraw
+    else
+        let username = g:leetcode_username
+        let password = saved_password
+    endif
+
+    return s:DoSignIn(username, password)
+endfunction
+
+function! leetcode#SignIn(ask) abort
+    if s:has_keyring
+        return s:KeyringSignIn(a:ask)
+    else
+        return s:LegacySignIn(a:ask)
     endif
-    return success
 endfunction
 
 function! s:CheckSignIn() abort
@@ -75,6 +123,7 @@ function! s:SetupProblemListBuffer() abort
     setlocal norelativenumber
     setlocal nospell
     setlocal bufhidden=hide
+    setlocal nowrap
     nnoremap <silent> <buffer> <return> :call <SID>HandleProblemListCR()<cr>
     nnoremap <silent> <buffer> s :call <SID>HandleProblemListS()<cr>
     nnoremap <silent> <buffer> r :call <SID>HandleProblemListR()<cr>
@@ -947,6 +996,7 @@ function! s:ListSubmissions(slug, refresh) abort
         setlocal nospell
         setlocal nonumber
         setlocal norelativenumber
+        setlocal nowrap
         nnoremap <silent> <buffer> <return> :call <SID>HandleSubmissionsCR()<cr>
         nnoremap <silent> <buffer> r :call <SID>HandleSubmissionsRefresh()<cr>
 

doc/leetcode.txt

@@ -56,7 +56,12 @@ g:leetcode_username Set it to the username/email to allow autologin.
                     Default: ''
 
                                                         *g:leetcode_password*
-g:leetcode_password Set it to the password to allow autologin.
+g:leetcode_password Deprecated in favor of keyring. Set it to the password to
+                    allow autologin.
+
+                    If you have installed keyring, then just leave this option
+                    blank. leetcode.vim will prompt for the password the first
+                    time you sign in, and store the password in keyring.
 
                     Default: ''