[DOCS] Add callback arg to setProps header in mount.md #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 15, 2017
| Manually sets state of the root component. | ||
|
|
||
| #### [`.setProps(nextProps) => ReactWrapper`](ReactWrapper/setProps.md) | ||
| #### [`.setProps(nextProps[, callback]) => ReactWrapper`](ReactWrapper/setProps.md) |
Member
There was a problem hiding this comment.
Thanks, does a similar change need to be made in the shallow docs?
Contributor
Author
There was a problem hiding this comment.
Without looking at any of the code, the documentation for shallow's setProps does not describe a callback argument.
ljharb
approved these changes
Aug 7, 2018
This was referenced Aug 8, 2018
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the signature as expressed in
setProps.md