Skip to content

Conversation

@bdwain
Copy link
Contributor

@bdwain bdwain commented Feb 23, 2018

Fixes #1488 by checking if a key is undefined, and if so, returning null.

Without the code changes, the new tests will fail with errors like this

AssertionError: expected undefined to equal null

@bdwain bdwain changed the title fix #1488 by returning null for missing keys return null for missing keys Feb 23, 2018
@bdwain
Copy link
Contributor Author

bdwain commented Feb 23, 2018

fixed lint errors

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

@ljharb ljharb merged commit 0efc948 into enzymejs:master Feb 23, 2018
@bdwain bdwain deleted the fix-key branch February 23, 2018 08:31
@bdwain
Copy link
Contributor Author

bdwain commented Feb 23, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants