fixed setProps execption swallowing issue and added regression test #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM. @ljharb I'm thinking this is a patch-level change as it's fixing a bug. Thoughts? |
lelandrichardson
added a commit
that referenced
this pull request
Feb 7, 2016
fixed setProps execption swallowing issue and added regression test
Member
|
I agree. I'm not entirely sure why the promise was there in the first place tho - is there some benefit it provided (beyond swallowing errors) that might make this a breaking change? |
This was referenced Oct 5, 2018
ghost
mentioned this pull request
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if there's a problem w this!