Skip to content

[New] shallow: setProps: add callback argument #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ljharb merged 2 commits into from
Jul 22, 2018
Merged

[New] shallow: setProps: add callback argument #1721

ljharb merged 2 commits into from
Jul 22, 2018

Conversation

@emuraton
Copy link
Contributor

@emuraton emuraton commented Jul 22, 2018 •
edited by ljharb
Loading

Fixes #1716

@emuraton emuraton changed the base branch from master to setProps July 22, 2018 00:18
emuraton
emuraton commented Jul 22, 2018
View reviewed changes
packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx Outdated
wrapper[sym('__renderer__')].batchedUpdates(() => {
wrapper.setProps({ id: 'bar', foo: 'bla' }, () => {
expect(wrapper.find('.bar')).to.have.lengthOf(1);
});
Copy link
Contributor Author

@emuraton emuraton Jul 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think callback argument is not supported for ShallowRendering
https://github.com/airbnb/enzyme/blob/master/packages/enzyme/src/ShallowWrapper.js#L381

Copy link
Member

@ljharb ljharb Jul 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but it probably should be - so that it's the same as mount

Copy link
Contributor Author

@emuraton emuraton Jul 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll update it 👍

@emuraton emuraton force-pushed the setProps-fix-test branch from e9e6e58 to 263bd2e Compare July 22, 2018 00:22
@emuraton emuraton mentioned this pull request Jul 22, 2018
Closed
@emuraton emuraton force-pushed the setProps-fix-test branch from bd296ef to eba0ebc Compare July 22, 2018 14:03
@ljharb ljharb force-pushed the setProps-fix-test branch from eba0ebc to 34d69ce Compare July 22, 2018 21:16
@ljharb ljharb changed the title Issue 1716 fix test [New] shallow: setProps: add callback argument Jul 22, 2018
@ljharb ljharb added the semver: minor New stuff. label Jul 22, 2018
@ljharb ljharb changed the base branch from setProps to master July 22, 2018 21:46
ljharb
ljharb approved these changes Jul 22, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

@ljharb ljharb merged commit 64051d9 into enzymejs:master Jul 22, 2018
This was referenced Aug 8, 2018
Open
Merged
Closed
Closed
This was referenced Oct 1, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

API: shallow semver: minor New stuff.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emuraton @ljharb