Merge pull request #35 from cretz/fix-tx-query-rows

Fix ReleasingTransaction::queryRows to use params

Author: alaisi

src/main/java/com/github/pgasync/impl/PgConnectionPool.java

@@ -269,7 +269,7 @@ public Observable<Row> queryRows(String sql, Object... params) {
             if (released.get()) {
                 return Observable.error(new SqlException("Transaction is already completed"));
             }
-            return transaction.queryRows(sql)
+            return transaction.queryRows(sql, params)
                     .doOnError(exception -> releaseConnection());
         }
 

src/test/java/com/github/pgasync/impl/TransactionTest.java

@@ -80,6 +80,18 @@ public void shouldCommitInsertInTransaction() throws Exception {
         assertEquals(10L, dbr.query("SELECT ID FROM TX_TEST WHERE ID = 10").row(0).getLong(0).longValue());
     }
 
+    @Test
+    public void shouldCommitParameterizedInsertInTransaction() throws Exception {
+        // Ref: https://github.com/alaisi/postgres-async-driver/issues/34
+        long id = dbr.db().begin().flatMap(txn ->
+            txn.queryRows("INSERT INTO TX_TEST (ID) VALUES ($1) RETURNING ID", "35").first().flatMap(row -> {
+                Long value = row.getLong(0);
+                return txn.commit().map(v -> value);
+            })
+        ).toBlocking().single();
+        assertEquals(35L, id);
+    }
+
     @Test
     public void shouldRollbackTransaction() throws Exception {
         CountDownLatch sync = new CountDownLatch(1);