Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aleph-im/pyaleph
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: aleph-im/pyaleph
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: od/make-default-messages-list-count-query-faster
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 24, 2025

  1. fix: avoid subqueries when calling /messages without parameters 

    The `/messages` endpoint returns the number of matching messages. As an
optimization for the default case with no filters, we return an
approximate (fast) count of the total number of messages, and accept the
performance penalty when specifying filters.

The condition to determine whether we go through the fast path was
weirdly designed (it depends on an empty `kwargs`) and new features
introduced a bug where the fast path is never used anymore.

This currently happens because of `start_block` and `end_block`, but
also `message_statuses`.

This PR fixes the issue for start/end blocks, the issue with message
statuses requires more investigation.
    @odesenfans
    odesenfans committed Oct 24, 2025
    Configuration menu
    Copy the full SHA
    f4e4b49 View commit details
    Browse the repository at this point in the history
Loading