Skip to content

Commit 20d3c21

Browse files
committed
Build a new starr first
We need 3 build stages, locker+quick is not enough, because of scaladoc and xml. Say we build scala `vLOCKER` with `vSTARR`, then the compilation classpath when compiling scaladoc contains `xml_vSTARR`. The `compiler.pom` will depend on `xml_vSTARR`. When we build quick, the `doc` command will run `scaladoc-vLOCKER` with `xml_vSTARR` on the runtime classpath. This is broken because `library-vLOCKER` might not provide what `xml_vSTARR` expects. In the the case of the new collections, `scala.collection.SeqLike` is missing. Note that this issue shows that we need to use the same version number for quick and locker, otherwise the quick `compiler.pom` will depend on the wrong version of xml.
1 parent 694fe79 commit 20d3c21

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
- determineScalaVersion
4343
- deriveModuleVersions
4444
- removeExistingBuilds $integrationRepoUrl
45+
- export STARR_REF=$TRAVIS_COMMIT # force starr to prevent running locker scaladoc with starr xml on the runtime classpath (=boom)
4546
- if [ ! -z "$STARR_REF" ]; then buildStarr; fi
4647
- buildLocker
4748
- buildQuick

0 commit comments

Comments
 (0)