Merge pull request #10516 from alphagov/edition-validity-issue

Stop 'invalid' organisations from blocking edits to publications (WHIT-2396)

Author: ChrisBAshton

app/models/concerns/edition/organisations.rb

@@ -90,6 +90,25 @@ def limits_access_via_organisations?
     true
   end
 
+  # Rails automatically defines methods called
+  # `validate_associated_records_for_<association>` for any association that is
+  # autosaved or validated. These methods run validations on each associated
+  # EditionOrganisation and Organisation, which causes an otherwise-valid edition
+  # to become invalid if any linked organisation is invalid (for example, because
+  # of an overlong custom_jobs_url). We don’t want an invalid organisation to
+  # block publication of an edition, so we override these methods to no-op.
+  #
+  # Presence and uniqueness of associated organisations are already enforced
+  # by our own custom validators, so skipping these auto-generated validations
+  # has no negative side-effects.
+  def validate_associated_records_for_edition_organisations
+    # no-op: prevent associated EditionOrganisation validations from running
+  end
+
+  def validate_associated_records_for_organisations
+    # no-op: prevent associated Organisation validations from running
+  end
+
 private
 
   def at_least_one_lead_organisation

test/unit/app/models/edition/organisations_test.rb

@@ -43,6 +43,31 @@ class Edition::OrganisationsTest < ActiveSupport::TestCase
     end
   end
 
+  test "should remain publishable when linked organisations are invalid" do
+    # Build and persist an organisation that will be invalid.
+    invalid_org = create(:organisation)
+    invalid_org.update_column(:homepage_type, "invalid")
+    assert_not invalid_org.valid?, "Homepage type is not included in the list"
+
+    # Create an edition using the invalid organisation as the lead organisation and
+    # disable default organisation creation. Persisting the edition mirrors real usage.
+    edition = create(
+      :publication,
+      create_default_organisation: false,
+      lead_organisations: [invalid_org],
+      supporting_organisations: [],
+    )
+
+    # The edition should be valid for publishing before any side-effects.
+    assert edition.valid?(:publish), "edition should be valid in publish context before touching organisations"
+
+    # Reading organisation names used to build unsaved translations and make the edition
+    # invalid via autosave validations:contentReference[oaicite:0]{index=0}. After overriding those validations,
+    # the edition should remain valid even after accessing organisation names.
+    edition.organisations.map(&:name)
+    assert edition.valid?(:publish), "edition should still be valid in publish context after reading organisation names"
+  end
+
   test "#sorted_organisations returns organisations in alphabetical order" do
     organisation1 = create(:organisation, name: "Ministry of Jazz")
     organisation2 = create(:organisation, name: "Free Jazz Foundation")