fix: Enable tree-shaking - #108
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # lerna.json # packages/example-advanced/package.json # packages/example/package.json # packages/next-intl/package.json # packages/use-intl/package.json # packages/use-intl/src/validateMessages.tsx
amannn
marked this pull request as ready for review
May 10, 2022 09:02
juanforlizzi
pushed a commit
to juanforlizzi/next-intl
that referenced
this pull request
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.npmjs.com/package/@formatjs/icu-messageformat-parser grew in size – that's the culprit.
Possibly we could provide a modern build as well like microbundle advertises it … However since the parser makes up the majority of the bundle size, the result might be negligible.
Could https://www.npmjs.com/package/@messageformat/parser be an alternative? Or just wait for native
Intl.MessageFormat.Fixes #107