Skip to content

Commit 124af16

Browse files
committed
Fix failing e2e tests due to changes in post preview button class names
1 parent 7423f59 commit 124af16

10 files changed

+8005
-3
lines changed

does not render the button when in Standard mode 2024-01-08T08-44-27-snapshot.html

Lines changed: 2000 additions & 0 deletions
Large diffs are not rendered by default.
39.7 KB
Loading

e2e-failure-artifacts.zip

395 KB
Binary file not shown.

is rendered on a new post 2024-01-08T08-42-21-snapshot.html

Lines changed: 2000 additions & 0 deletions
Large diffs are not rendered by default.
55.8 KB
Loading

is rendered when a post has content 2024-01-08T08-43-25-snapshot.html

Lines changed: 2000 additions & 0 deletions
Large diffs are not rendered by default.
65 KB
Loading

should display even when Gutenberg is not active 2024-01-08T08-47-03-snapshot.html

Lines changed: 1997 additions & 0 deletions
Large diffs are not rendered by default.
38.5 KB
Loading

tests/e2e/specs/block-editor/amp-preview-button.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,14 @@ import {
1212
deactivatePlugin,
1313
} from '../../utils/amp-settings-utils';
1414

15-
const postPreviewBtnSelector = '.components-button.editor-post-preview';
15+
const postPreviewBtnSelector =
16+
'.components-button.edit-post-header__post-preview-button';
1617
const ampPreviewBtnSelector = `${postPreviewBtnSelector} + .amp-wrapper-post-preview > .amp-editor-post-preview`;
1718

19+
// Remove legacy selectors once changes of <https://github.com/WordPress/gutenberg/pull/56921> lands in WP core.
20+
const legacyPreviewBtnSelector = '.components-button.editor-post-preview';
21+
const legacyAmpPreviewBtnSelector = `${legacyPreviewBtnSelector} + .amp-wrapper-post-preview > .amp-editor-post-preview`;
22+
1823
describe('AMP Preview button', () => {
1924
it('is rendered on a new post', async () => {
2025
await createNewPost();
@@ -27,9 +32,9 @@ describe('AMP Preview button', () => {
2732
await deactivatePlugin('gutenberg');
2833

2934
await createNewPost();
30-
await page.waitForSelector(postPreviewBtnSelector);
35+
await page.waitForSelector(legacyPreviewBtnSelector);
3136

32-
await expect(page).toMatchElement(ampPreviewBtnSelector);
37+
await expect(page).toMatchElement(legacyAmpPreviewBtnSelector);
3338

3439
await activatePlugin('gutenberg');
3540
});

0 commit comments

Comments
 (0)