update to compilable version

enable self signed certs (where chain.Count==1) only in iOS yet
merge parts of https://github.com/Youscribe/ModernHttpClient/blob/hotfix/cycle8-issue/src/ModernHttpClient/Android/OkHttpNetworkHandler.cs

Author: MichaelRumpler

ModernHttpClient.sln

@@ -116,26 +116,18 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
             // NB: Even closing a socket must be done off the UI thread. Cray!
             cancellationToken.Register(() => Task.Run(() => call.Cancel()));
 
-            var resp = default(Response);
-            try {
-                resp = await call.EnqueueAsync().ConfigureAwait(false);
-                var newReq = resp.Request();
-                var newUri = newReq == null ? null : newReq.Uri();
-                request.RequestUri = new Uri(newUri.ToString());
-                if (throwOnCaptiveNetwork && newUri != null) {
-                    if (url.Host != newUri.Host) {
-                        throw new CaptiveNetworkException(new Uri(java_uri), new Uri(newUri.ToString()));
-                    }
-                }
-            } catch (IOException ex) {
-                if (ex.Message.ToLowerInvariant().Contains("canceled")) {
-                    throw new OperationCanceledException();
-                }
-
-                throw;
-            }
-
-            var respBody = resp.Body();
+			var resp = await call.EnqueueAsync().ConfigureAwait(false);
+			var newReq = resp.Request();
+			var newUri = newReq == null ? null : newReq.Uri();
+			request.RequestUri = new Uri(newUri.ToString());
+
+			if (throwOnCaptiveNetwork && newUri != null)
+			{
+				if (url.Host != newUri.Host)
+					throw new CaptiveNetworkException(new Uri(java_uri), new Uri(newUri.ToString()));
+			}
+			
+			var respBody = resp.Body();
 
             cancellationToken.ThrowIfCancellationRequested();
 
@@ -180,8 +172,12 @@ public void OnFailure(Request p0, Java.IO.IOException p1)
                 // Kind of a hack, but the simplest way to find out that server cert. validation failed
                 if (p1.Message == String.Format("Hostname '{0}' was not verified", p0.Url().Host)) {
                     tcs.TrySetException(new WebException(p1.LocalizedMessage, WebExceptionStatus.TrustFailure));
-                } else {
-                    tcs.TrySetException(p1);
+				}
+				else if (p1.Message.ToLowerInvariant().Contains("canceled"))
+				{
+					tcs.TrySetException(new System.OperationCanceledException());
+				} else {
+                    tcs.TrySetException(new WebException(p1.Message));
                 }
             }
 
@@ -198,7 +194,7 @@ class HostnameVerifier : Java.Lang.Object, IHostnameVerifier
 
         public bool Verify(string hostname, ISSLSession session)
         {
-            return verifyServerCertificate(hostname, session) & verifyClientCiphers(hostname, session);
+            return verifyServerCertificate(hostname, session);
         }
 
         /// <summary>
@@ -224,12 +220,13 @@ static bool verifyServerCertificate(string hostname, ISSLSession session)
             if (certificates == null || certificates.Length == 0) {//no cert at all
                 errors = System.Net.Security.SslPolicyErrors.RemoteCertificateNotAvailable;
                 goto bail;
-            } 
+            }
 
-            if (certificates.Length == 1) {//no root?
-                errors = System.Net.Security.SslPolicyErrors.RemoteCertificateChainErrors;
-                goto bail;
-            } 
+			// this disables self signed certificates
+			//if (certificates.Length == 1) {//no root?
+   //             errors = System.Net.Security.SslPolicyErrors.RemoteCertificateChainErrors;
+   //             goto bail;
+   //         } 
 
             var netCerts = certificates.Select(x => new X509Certificate2(x.GetEncoded())).ToArray();
 
@@ -261,22 +258,5 @@ static bool verifyServerCertificate(string hostname, ISSLSession session)
             // Call the delegate to validate
             return ServicePointManager.ServerCertificateValidationCallback(hostname, root, chain, errors);
         }
-
-        /// <summary>
-        /// Verifies client ciphers and is only available in Mono and Xamarin products.
-        /// </summary>
-        /// <returns><c>true</c>, if client ciphers was verifyed, <c>false</c> otherwise.</returns>
-        /// <param name="hostname"></param>
-        /// <param name="session"></param>
-        static bool verifyClientCiphers(string hostname, ISSLSession session)
-        {
-            var callback = ServicePointManager.ClientCipherSuitesCallback;
-            if (callback == null) return true;
-
-            var protocol = session.Protocol.StartsWith("SSL", StringComparison.InvariantCulture) ? SecurityProtocolType.Ssl3 : SecurityProtocolType.Tls;
-            var acceptedCiphers = callback(protocol, new[] { session.CipherSuite });
-
-            return acceptedCiphers.Contains(session.CipherSuite);
-        }
     }
 }

src/ModernHttpClient/Android/OkHttpNetworkHandler.cs

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -13,9 +13,9 @@
     <AndroidResgenClass>Resource</AndroidResgenClass>
     <MonoAndroidResourcePrefix>Resources</MonoAndroidResourcePrefix>
     <MonoAndroidAssetsPrefix>Assets</MonoAndroidAssetsPrefix>
-    <AndroidUseLatestPlatformSdk>False</AndroidUseLatestPlatformSdk>
+    <AndroidUseLatestPlatformSdk>True</AndroidUseLatestPlatformSdk>
     <AssemblyName>ModernHttpClient</AssemblyName>
-    <TargetFrameworkVersion>v2.3</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v7.0</TargetFrameworkVersion>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>
@@ -49,9 +49,7 @@
     <Compile Include="Android\OkHttpNetworkHandler.cs" />
     <None Include="Resources\AboutResources.txt" />
     <AndroidResource Include="Resources\values\Strings.xml" />
-    <Folder Include="Android\Properties\" />
     <Compile Include="Android\ConcatenatingStream.cs" />
-    <Folder Include="Properties\" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="ProgressStreamContent.cs" />
     <Compile Include="Utility.cs" />
@@ -65,5 +63,8 @@
       <HintPath>..\..\packages\Square.OkHttp.2.4.0.3\lib\MonoAndroid\Square.OkHttp.dll</HintPath>
     </Reference>
   </ItemGroup>
+  <ItemGroup>
+    <Folder Include="Android\Properties\" />
+  </ItemGroup>
   <Import Project="$(MSBuildExtensionsPath)\Novell\Novell.MonoDroid.CSharp.targets" />
-</Project>
+</Project>

src/ModernHttpClient/ModernHttpClient.Android.csproj

@@ -303,10 +303,11 @@ public override void DidReceiveChallenge(NSUrlSession session, NSUrlSessionTask
                     goto sslErrorVerify;
                 }
 
-                if (serverCertChain.Count == 1) {
-                    errors = SslPolicyErrors.RemoteCertificateChainErrors;
-                    goto sslErrorVerify;
-                }
+				// this disables self signed certificates
+                //if (serverCertChain.Count == 1) {
+                //    errors = SslPolicyErrors.RemoteCertificateChainErrors;
+                //    goto sslErrorVerify;
+                //}
 
                 var netCerts = Enumerable.Range(0, serverCertChain.Count)
                     .Select(x => serverCertChain[x].ToX509Certificate2())

src/ModernHttpClient/Resources/Resource.designer.cs

@@ -49,12 +49,6 @@ protected override void OnCreate (Bundle bundle)
             // Set our view from the "main" layout resource
             SetContentView (Resource.Layout.Main);
 
-            //This API is only available in Mono and Xamarin products.
-            //You can filter and/or re-order the ciphers suites that the SSL/TLS server will accept from a client.
-            //The following example removes weak (export) ciphers from the list that will be offered to the server.
-            ServicePointManager.ClientCipherSuitesCallback += (protocol, allCiphers) =>
-                allCiphers.Where(x => !x.Contains("EXPORT")).ToList();
-
             //Here we accept any certificate and just print the cert's data.
             ServicePointManager.ServerCertificateValidationCallback += (sender, certificate, chain, sslPolicyErrors) => {
                 System.Diagnostics.Debug.WriteLine("Callback Server Certificate: " + sslPolicyErrors);

src/ModernHttpClient/iOS/NSUrlSessionHandler.cs

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -14,9 +14,9 @@
     <AndroidResgenClass>Resource</AndroidResgenClass>
     <MonoAndroidResourcePrefix>Resources</MonoAndroidResourcePrefix>
     <MonoAndroidAssetsPrefix>Assets</MonoAndroidAssetsPrefix>
-    <AndroidUseLatestPlatformSdk>False</AndroidUseLatestPlatformSdk>
+    <AndroidUseLatestPlatformSdk>True</AndroidUseLatestPlatformSdk>
     <AssemblyName>Playground.Android</AssemblyName>
-    <TargetFrameworkVersion>v4.0.3</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v7.0</TargetFrameworkVersion>
     <AndroidManifest>Properties\AndroidManifest.xml</AndroidManifest>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
@@ -81,4 +81,4 @@
       <Name>ModernHttpClient.Android</Name>
     </ProjectReference>
   </ItemGroup>
-</Project>
+</Project>

src/Playground.Android/MainActivity.cs

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="Playground.Android">
 	<uses-sdk android:minSdkVersion="15" android:targetSdkVersion="15" />
-	<application android:label="Playground.Android">
-	</application>
+	<application android:label="Playground.Android"></application>
 	<uses-permission android:name="android.permission.INTERNET" />
 </manifest>

src/Playground.Android/Playground.Android.csproj

@@ -31,12 +31,6 @@ public Playground_iOSViewController () : base ("Playground_iOSViewController", n
             });
             */
 
-            //This API is only available in Mono and Xamarin products.
-            //You can filter and/or re-order the ciphers suites that the SSL/TLS server will accept from a client.
-            //The following example removes weak (export) ciphers from the list that will be offered to the server.
-            ServicePointManager.ClientCipherSuitesCallback += (protocol, allCiphers) =>
-                allCiphers.Where(x => !x.Contains("EXPORT")).ToList();
-
             //Here we accept any certificate and just print the cert's data.
             ServicePointManager.ServerCertificateValidationCallback += (sender, certificate, chain, sslPolicyErrors) => {
                 System.Diagnostics.Debug.WriteLine("Callback Server Certificate: " + sslPolicyErrors);