Skip to content

Commit 952c54f

Browse files
puredangerstuarthalloway
authored andcommitted
CLJ-1723 Expanding transducer fails if adding nil values
Signed-off-by: Stuart Halloway <[email protected]>
1 parent d91ffba commit 952c54f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/jvm/clojure/lang/TransformerIterator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import java.util.List;
1717
import java.util.NoSuchElementException;
1818
import java.util.Queue;
19-
import java.util.concurrent.ConcurrentLinkedQueue;
19+
import java.util.LinkedList;
2020

2121
public class TransformerIterator implements Iterator {
2222

@@ -169,7 +169,7 @@ public String toString() {
169169
}
170170

171171
private static class Many implements Buffer {
172-
private final Queue vals = new ConcurrentLinkedQueue();
172+
private final Queue vals = new LinkedList();
173173

174174
public Many(Object o1, Object o2) {
175175
vals.add(o1);

test/clojure/test_clojure/transducers.clj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,10 @@
347347
(is (= ["drib" "god" "hsif" "kravdraa" "tac"]
348348
(->> ["cat" "dog" "fish" "bird" "aardvark"]
349349
(eduction (map clojure.string/reverse))
350-
(sort-by first))))))
350+
(sort-by first)))))
351+
(testing "expanding transducer with nils"
352+
(is (= '(1 2 3 nil 4 5 6 nil)
353+
(eduction cat [[1 2 3 nil] [4 5 6 nil]])))))
351354

352355
(deftest test-eduction-completion
353356
(testing "eduction completes inner xformed reducing fn"

0 commit comments

Comments
 (0)