fix(github_nulls): Better handling of Nulls in GitHub API (#39)

shiro · web-flow · commit 6744d11f8328 · 2023-05-24T21:29:39.000-05:00
* fix(branch_protections.py): Handle null GitHub Elements

Corrects issue where GitHub repo currently contains no elements, but config file does

* fix(branch_protections.py): Handle null GitHub Elements
diff --git a/repo_manager/github/branch_protections.py b/repo_manager/github/branch_protections.py
@@ -285,21 +285,27 @@ def check_repo_branch_protections(
                 diff_option(
                     "required_approving_review_count",
                     config_bp.protection.pr_options.required_approving_review_count,
-                    this_protection.required_pull_request_reviews.required_approving_review_count,
+                    ## Had issues when the YAML defines this but the Repo has none (e.g. it's null in the cloud)
+                    None if (this_protection.required_pull_request_reviews is None) else \
+                        this_protection.required_pull_request_reviews.required_approving_review_count,
                 )
             )
             diffs.append(
                 diff_option(
                     "dismiss_stale_reviews",
                     config_bp.protection.pr_options.dismiss_stale_reviews,
-                    this_protection.required_pull_request_reviews.dismiss_stale_reviews,
+                    ## Had issues when the YAML defines this but the Repo has none (e.g. it's null in the cloud)
+                    None if (this_protection.required_pull_request_reviews is None) else \
+                        this_protection.required_pull_request_reviews.dismiss_stale_reviews,
                 )
             )
             diffs.append(
                 diff_option(
                     "require_code_owner_reviews",
                     config_bp.protection.pr_options.require_code_owner_reviews,
-                    this_protection.required_pull_request_reviews.require_code_owner_reviews,
+                    ## Had issues when the YAML defines this but the Repo has none (e.g. it's null in the cloud)
+                    None if (this_protection.required_pull_request_reviews is None) else \
+                        this_protection.required_pull_request_reviews.require_code_owner_reviews,
                 )
             )
             # for now, not checking dismissal options. Will note that in the docs

Original file line number	Diff line number	Diff line change
`@@ -285,21 +285,27 @@ def check_repo_branch_protections(`
`285`	`285`	`diff_option(`
`286`	`286`	`"required_approving_review_count",`
`287`	`287`	`config_bp.protection.pr_options.required_approving_review_count,`
`288`		`- this_protection.required_pull_request_reviews.required_approving_review_count,`
	`288`	`+ ## Had issues when the YAML defines this but the Repo has none (e.g. it's null in the cloud)`
	`289`	`+ None if (this_protection.required_pull_request_reviews is None) else \`
	`290`	`+ this_protection.required_pull_request_reviews.required_approving_review_count,`
`289`	`291`	`)`
`290`	`292`	`)`
`291`	`293`	`diffs.append(`
`292`	`294`	`diff_option(`
`293`	`295`	`"dismiss_stale_reviews",`
`294`	`296`	`config_bp.protection.pr_options.dismiss_stale_reviews,`
`295`		`- this_protection.required_pull_request_reviews.dismiss_stale_reviews,`
	`297`	`+ ## Had issues when the YAML defines this but the Repo has none (e.g. it's null in the cloud)`
	`298`	`+ None if (this_protection.required_pull_request_reviews is None) else \`
	`299`	`+ this_protection.required_pull_request_reviews.dismiss_stale_reviews,`
`296`	`300`	`)`
`297`	`301`	`)`
`298`	`302`	`diffs.append(`
`299`	`303`	`diff_option(`
`300`	`304`	`"require_code_owner_reviews",`
`301`	`305`	`config_bp.protection.pr_options.require_code_owner_reviews,`
`302`		`- this_protection.required_pull_request_reviews.require_code_owner_reviews,`
	`306`	`+ ## Had issues when the YAML defines this but the Repo has none (e.g. it's null in the cloud)`
	`307`	`+ None if (this_protection.required_pull_request_reviews is None) else \`
	`308`	`+ this_protection.required_pull_request_reviews.require_code_owner_reviews,`
`303`	`309`	`)`
`304`	`310`	`)`
`305`	`311`	`# for now, not checking dismissal options. Will note that in the docs`