This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): disable title button when in max mode#3012
Closed
kevinoid wants to merge 1 commit intoangular-ui:masterfrom
Closed
fix(datepicker): disable title button when in max mode#3012kevinoid wants to merge 1 commit intoangular-ui:masterfrom
kevinoid wants to merge 1 commit intoangular-ui:masterfrom
Conversation
When the calendar is in the maximum configured mode, clicking the title button has no effect. To convey this to users, make the non-functional button non-clickable, and take the button out of focus order, disable the button when in the maximum mode. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Contributor
|
This looks good, merged |
Contributor
Author
|
Great. Thanks for the review and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the calendar is in the maximum configured mode, clicking the title button has no effect. To convey this to users, facilitate styling of this state with CSS, make the non-functional button non-clickable, and to take the button out of focus order, I suggest that the title button be disabled when in the maximum mode. This PR implements that change.
I appreciate your consideration and welcome your feedback.
Thanks,
Kevin