This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(popover): animations with ngAnimate#3509
Closed
chrisirhc wants to merge 1 commit intoangular-ui:masterfrom
Closed
fix(popover): animations with ngAnimate#3509chrisirhc wants to merge 1 commit intoangular-ui:masterfrom
chrisirhc wants to merge 1 commit intoangular-ui:masterfrom
Conversation
- Animations didn't work because the class attribute was mangled during compilation due to the way class attributes are merged on directives with `replace: true` - Rename attribute to popup-class - Refactor to rename variables named "class" as it's a keyword and also looks weird in editors Fixes angular-ui#3375 Fixes angular-ui#3506
chrisirhc
force-pushed
the
feature/fix-tooltip-animate
branch
from
d282e22 to
ed0416e
Compare
Contributor
|
LGTM - this is ready I take it? |
Contributor
Author
|
Yep it's ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compilation due to the way class attributes are merged on directives with
replace: true(happenedand also looks weird in editors
Fixes #3375
Fixes #3506