This repository was archived by the owner on May 29, 2019. It is now read-only.
Added support for dropdown-menu being right aligned, see angular-ui/bootstrap#3820#3913
Closed
schmuli wants to merge 1 commit intoangular-ui:masterfrom
schmuli:dropmenu-menu-right
Closed
Added support for dropdown-menu being right aligned, see angular-ui/bootstrap#3820#3913schmuli wants to merge 1 commit intoangular-ui:masterfrom schmuli:dropmenu-menu-right
schmuli wants to merge 1 commit intoangular-ui:masterfrom
schmuli:dropmenu-menu-right
Conversation
Bootstrap has a 'dropdown-menu-right' class, which is used to display a dropdown menu aligned to the right edge of the toggle, rather than the left. This PR adds a check in the case of append-to-body, and calculates the correct right-aligned position of the dropdown menu element.
Contributor
|
This looks good - here is a Plunker with your changes for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap has a 'dropdown-menu-right' class, which is used to display a dropdown menu aligned to the right edge of the toggle, rather than the left.
This PR adds a check in the case of append-to-body, and calculates the correct right-aligned position of the dropdown menu element.
This would then be able to close #3820.