This repository was archived by the owner on May 29, 2019. It is now read-only.
datepicker-popup can be nested within another dropdown#4489
Closed
sullivanpt wants to merge 1 commit intoangular-ui:masterfrom
Closed
datepicker-popup can be nested within another dropdown#4489sullivanpt wants to merge 1 commit intoangular-ui:masterfrom
sullivanpt wants to merge 1 commit intoangular-ui:masterfrom
Conversation
A dropdown-menu can be nested within a parent dropdown without adversely affecting the parent, if the child dopdown-menu element also has the dropdown-nested attribute defined. Closes angular-ui#4197
Contributor
|
I'm ok with this hack for now I think - when the datepicker prefix work gets in, we'll have a better option with requiring the datepicker popup controller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #4197. The underlying issue is the directive 'require' attribute for the date picker pop-up is incorrectly finding the parent dropdown controller.
A dropdown-menu can be nested within a parent dropdown without
adversely affecting the parent, if the child dopdown-menu element
also has the dropdown-nested attribute defined.