This repository was archived by the owner on May 29, 2019. It is now read-only.
Fix calculation of progressbar on removed bar#4588
Closed
wesleycho wants to merge 2 commits intoangular-ui:masterfrom
Closed
Fix calculation of progressbar on removed bar#4588wesleycho wants to merge 2 commits intoangular-ui:masterfrom
wesleycho wants to merge 2 commits intoangular-ui:masterfrom
Conversation
- Fix percentage calculation when bars are altered
Contributor
|
Seems fine to me Wes. Progressbar is my cursed lib (tests that only fails to me) so /shrug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the percentage calculation when a bar is removed.
This fixes #4452, and adds the unit test from #4471, as well as fixes the code style and commit message.
I am not sure why the release commit is listed in the history here, as that is from
masterand I rancurl ... | git am -3, which should have rebased the original commit on top ofmaster.Edit: History is fixed