This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(dateparser): enforce order of regex construction#4810
Closed
wesleycho wants to merge 1 commit intoangular-ui:masterfrom
Closed
fix(dateparser): enforce order of regex construction#4810wesleycho wants to merge 1 commit intoangular-ui:masterfrom
wesleycho wants to merge 1 commit intoangular-ui:masterfrom
Conversation
- Change `formatCodeToRegex` into an array to avoid potential iteration bug where the order the keys are listed in the object matters in the iteration order
Contributor
|
Better. Merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatCodeToRegexinto an array to avoid potential iteration bug where the order the keys are listed in the object matters in the iteration orderThis fixes #4808.