Modal: pass the closedDeferred promise to removeAfterAnimate function

[javix]

If I close the modal the closed promise will not be called.

modalInstance.closed.then(function() {
    console.log('closed', arguments);
});

[Foxandxss]

Sure, let me grab my crystal ball and figure out what is the purpose of this PR.

[javix]

Hallo,
I am little bit confused about the failed tests and about the implementation of the function toBeResolvedWith in modal.spec.js.

The promise closedDeferred will be resolved only in the function afterAnimating() in modal.js line 369.
I added console.log("afterAnimating", closedDeferred); in the function afterAnimating() (line 359).
Without my changes, I get follow output with log level DEBUG

LOG: 'afterAnimating', undefined

and the line closedDeferred.resolve(); will not be called.

With my changes, I get

LOG: 'afterAnimating', Deferred{promise: Promise{$$state: Object{status: ...}}, resolve: function (value) { ... }, reject: function (value) { ... }, notify: function (value) { ... }}

[Foxandxss]

I see, my friend @wesleycho is looking into it.

Thanks.

[wesleycho]

@armagedon looks like somehow the tests were flawed for this - I fixed them in #5326.