This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(tab): make active optional#5489
Closed
RobJacobs wants to merge 1 commit intoangular-ui:masterfrom
RobJacobs:tab-active
Closed
fix(tab): make active optional#5489RobJacobs wants to merge 1 commit intoangular-ui:masterfrom RobJacobs:tab-active
RobJacobs wants to merge 1 commit intoangular-ui:masterfrom
RobJacobs:tab-active
Conversation
src/tabs/test/tabs.spec.js
Outdated
| expectContents(['first content is 1', 'second content is 2']); | ||
| expect(titles().eq(0)).toHaveClass('active'); | ||
| expect(titles().eq(1)).not.toHaveClass('active'); | ||
| expect(scope.active).toBe(1); |
Contributor
There was a problem hiding this comment.
This is the wrong way to test this - you need to grab the controller via elm.controller('uibTabset') and check active on that
Contributor
Author
There was a problem hiding this comment.
DOH! Sorry I missed that, I'm surprised it didn't fail when running the test in Chrome?
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the active binding added under #5425 optional. Plunk with updated code.