This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): watch for changes when falsy#5677
Closed
wesleycho wants to merge 1 commit intoangular-ui:masterfrom
Closed
feat(datepicker): watch for changes when falsy#5677wesleycho wants to merge 1 commit intoangular-ui:masterfrom
wesleycho wants to merge 1 commit intoangular-ui:masterfrom
Conversation
wesleycho
force-pushed
the
fix/datepicker-min-watch
branch
from
ffdb24c to
6e2eb05
Compare
wesleycho
changed the title
- When initial value is falsy, continue to watch for changes to update
wesleycho
force-pushed
the
fix/datepicker-min-watch
branch
from
6e2eb05 to
5bb0463
Compare
Contributor
|
Do we need a doc update for this? If not, LGTM. |
Contributor
Author
|
It's already marked as watched, this just makes it behave more naturally according to the docs. |
Contributor
|
Cool. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #5672.