This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(loading): add "index-nocss.js" files#5696
Closed
onlywei wants to merge 1 commit intoangular-ui:masterfrom
Closed
feat(loading): add "index-nocss.js" files#5696onlywei wants to merge 1 commit intoangular-ui:masterfrom
onlywei wants to merge 1 commit intoangular-ui:masterfrom
Conversation
Contributor
|
This needs an exclusion added to https://github.com/angular-ui/bootstrap/blob/master/karma.conf.js#L29-L32 |
This allows SystemJS users to load the individual modules without setting up CSS loading. Some build processes with using SystemJS would rather have a custom, separate CSS loading solution. This commit allows that to happen.
Contributor
Author
|
Hmm, not really sure what this means: |
Contributor
|
Interesting failure - restarted the CI task |
Contributor
|
Hmm, maybe Travis is having issues - I'll hold off for a few days and come back to it. FWIW, this LGTM, and will likely be merged without any need for further changes on your end. |
Contributor
|
I found out what was the error - it was a legitimate error where the Gruntfile also needed to be modified - I fixed it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows SystemJS users to load the individual
modules without setting up CSS loading. Some build
processes with using SystemJS would rather have
a custom, separate CSS loading solution. This
commit allows that to happen.