fix(modal): ensure correct index is set for new modals#5733
fix(modal): ensure correct index is set for new modals#5733josetaira wants to merge 5 commits intoangular-ui:masterfrom josetaira:fix-multiple-modal-index
Conversation
Fix how the index for the modal and the backdrop are set, depending on what index value the previous top modal has. Closes #5670
src/modal/modal.js
Outdated
|
|
||
| // If any backdrop exist, ensure that it's index is always | ||
| // right below the top modal | ||
| if(topBackdropIndex > -1 && topBackdropIndex < topModalIndex) { |
|
Can you add a unit test for this? |
Fix the formatting comments of wesleycho on recent commit for modal fix Closes #5670
|
For the tests, no idea how grunt works, but I guess I can learn it. Do you have any templates or guidelines on how tests should be made? |
|
@josetaira, you don't need to learn grunt, you need to look at the if you want to run a specific test or test suite, simply prefix the |
Add code that adjusts the angularDomEl index properly based on topModalIndex. Just forgot to add this to the initial commit. Closes #5670
|
@icfantv Thanks for the info. Working on the unit tests now. Seems I did have to use grunt to create some templates (run |
|
@josetaira good deal. |
|
@icfantv @wesleycho tests committed. |
|
This LGTM - thanks for the effort! |
Fix how the index for the modal and the backdrop are set, depending on
what index value the previous top modal has.
Closes #5670