This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(tab): fix event handler call#5738
Closed
icfantv wants to merge 1 commit intoangular-ui:masterfrom
Closed
Conversation
* switch event handler call to look at `event.isDefaultPrevented()` instead of `event.defaultPrevented` as angular has implemented that method on jqlite events. Fixes angular-ui#5720
Contributor
|
LGTM |
Contributor
|
Did this not need an associated test change? |
Contributor
Author
|
@deeg the test was already in there from the original fix applied for this issue from last week. the issue is that we don't have separate karma files for testing with and without jquery. i opened an issue to track that. also see the thread in our slack for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event.isDefaultPrevented()instead ofevent.defaultPreventedas angular has implemented that method on jqliteevents.
Fixes #5720