This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(typeahead): use $setViewValue on blur#5769
Closed
pdesgarets wants to merge 1 commit intoangular-ui:masterfrom
pdesgarets:fix-validators
Closed
fix(typeahead): use $setViewValue on blur#5769pdesgarets wants to merge 1 commit intoangular-ui:masterfrom pdesgarets:fix-validators
pdesgarets wants to merge 1 commit intoangular-ui:masterfrom
pdesgarets:fix-validators
Conversation
Use $setViewValue instead of setting directly $viewValue to '', to make new value go through validators.
Contributor
|
This LGTM - setting the view value directly may have been a result of some legacy code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On blur, use $setViewValue instead of setting directly $viewValue to '', to make new value go through $validators.
Especially useful when required directive is used.
May fix #5694 (I'm not sure I have understood what was your problem, @sv311 ); updated plnkr : http://plnkr.co/edit/tNrdiMzI9zCeMdrRSSS9?p=preview