This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): Fix alignment for dropdown-append-to-body with .dropdown-menu-right when there's a vertical scrollbar#5830
Closed
dolevd wants to merge 1 commit intoangular-ui:masterfrom
Conversation
Contributor
|
This LGTM - @RobJacobs is this the right fix? |
Contributor
|
LGTM |
|
When there is no vertical scroll bar, the position of the dropdown is now incorrect. |
Contributor
Author
|
Can you please provide a plunkr that shows the problem? |
|
Here is the Plunkr. |
Contributor
Author
|
Thanks. My code is missing a check for overflow. |
|
Thanks for the quick action! |
Contributor
Author
|
I have a fix in my fork: dolevd@f838eb6 However, this might create a performance issue (since we need to calculate the styles of the append to element on every watch). |
Contributor
Author
|
I've opened another issue to handle this (#5942), since I don't think anyone is looking at the comments here anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4317
This is going to be difficult to add tests for as the width of the scrollbar (that's used to calculate the alignment) is browser dependent.
Plunk with fix in place.