This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): add monthColumns to DatepickerConfig#5935
Closed
Mrman wants to merge 1 commit intoangular-ui:masterfrom
Closed
feat(datepicker): add monthColumns to DatepickerConfig#5935Mrman wants to merge 1 commit intoangular-ui:masterfrom
Mrman wants to merge 1 commit intoangular-ui:masterfrom
Conversation
src/datepicker/datepicker.js
Outdated
|
|
||
| this.init = function(ctrl) { | ||
| angular.extend(ctrl, this); | ||
| columns = ctrl.monthColumns; |
Contributor
There was a problem hiding this comment.
Why does this need to be stored - couldn't one just use ctrl.monthColumns when needed?
Contributor
Author
|
@wesleycho thanks for review comments. Have updated the PR with the changes. Let me know if theres anything else. |
Contributor
|
@wesleycho, what needed work on this? is it good to merge or do we need more info? |
Contributor
Author
|
Would love to get this into the next release. Do let me know if anything is outstanding. Addressed all the comments raised in the initial review. |
Contributor
|
Sorry for the long wait - this LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5515