This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(pagination): disable tabbing when disabled#5984
Closed
wesleycho wants to merge 1 commit intoangular-ui:masterfrom
Closed
feat(pagination): disable tabbing when disabled#5984wesleycho wants to merge 1 commit intoangular-ui:masterfrom
wesleycho wants to merge 1 commit intoangular-ui:masterfrom
Conversation
wesleycho
force-pushed
the
feat/pagination-disabled
branch
4 times, most recently
from
32b5d48 to
126cdc1
Compare
- Add directive for toggling `tabindex="-1"` when ngDisabled is true, and removing tabindex when false
wesleycho
force-pushed
the
feat/pagination-disabled
branch
from
126cdc1 to
1a0df5b
Compare
Contributor
|
Build restarted. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tabindex="-1"when ngDisabled is true, and removing tabindex when falseFeature in action here.
This should implement #5151.