This repository was archived by the owner on May 29, 2019. It is now read-only.
refactor(datepickerSpec): speed up tests #1499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were compiling the element multiple times unnecessarily as it's done in the root describe's beforeEach. Introduce describe blocks with no name to encapsulate tests that need the element to be compiled and separate them from tests that have their own compilation.
Contributor
|
That is an useful option in karma (I don't use karma myself). And making tests faster is always good. If we have a lot of watches, that is something to lookup next :) |
Member
|
Simply awesome! It cuts down the Karma run time from ~12s to ~8s on my MBP. Thnx so much @chrisirhc ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were compiling the element multiple times unnecessarily as it's done in the root describe's beforeEach.
Introduce describe blocks with no name to encapsulate tests that need the element to be compiled and separate them from tests that have their own compilation.
Using the
reportSlowerThanoption of karma, I found that the datepicker tests are running the slowest. This is also an indication that we might have a lot of watchers in datepicker. It's a rather complicated widget.No changes in the testing at all. Only indentation and moving things around.
Before:
After:
