fix(@angular/cli): remove unneeded dependencies#4473
Merged
Conversation
|
CLAs look good, thanks! |
Brocco
reviewed
Feb 7, 2017
| "dependencies": { | ||
| "@angular/compiler": "^2.3.1", | ||
| "@angular/compiler-cli": "^2.3.1", | ||
| "@angular/core": "^2.3.1", |
Contributor
There was a problem hiding this comment.
If you're dropping @angular/core shouldn't you also drop the recently added rxjs dependency?
2ac086b to
2995922
Compare
Brocco
approved these changes
Feb 7, 2017
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
Closed
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 10, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 10, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 10, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 13, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Feb 13, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
|
When I have tried to install |
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.