Service worker in the CLI#4544
Closed
alxhub wants to merge 2 commits into
Closed
Conversation
hansl
suggested changes
Feb 9, 2017
Contributor
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Few nits and questions, nothing major. Good work!
| "index": "index.html", | ||
| "main": "main.ts", | ||
| "polyfills": "polyfills.ts", | ||
| "serviceWorker": false, |
Contributor
There was a problem hiding this comment.
Since the default is false, any reason to include this?
Member
Author
There was a problem hiding this comment.
Discoverability, really.
Removing it :)
| "homepage": "https://github.com/angular/angular-cli", | ||
| "dependencies": { | ||
| "@ngtools/json-schema": "^1.0.0", | ||
| "@angular/service-worker": "1.0.0-beta.3", |
Contributor
There was a problem hiding this comment.
Didn't we say this was an optional dep?
Member
Author
There was a problem hiding this comment.
Optional for the end user project.
| "npm": ">= 3.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@angular/service-worker": "1.0.0-beta.3", |
Contributor
There was a problem hiding this comment.
This shouldn't be here, since the webpack plugin itself doesnt use the service worker.
| .then(() => ng('build', '--prod')) | ||
| .then(() => expectFileToExist(join(process.cwd(), 'dist'))) | ||
| .then(() => expectFileToExist(join(process.cwd(), 'dist/ngsw-manifest.json'))) | ||
| .then(() => ng('set', 'apps.0.serviceWorker=false')); |
Contributor
There was a problem hiding this comment.
No need to reset after a test, it's git clean-ed.
… added before completing
alxhub
force-pushed
the
sw-support
branch
6 times, most recently
from
ac2e319 to
55ac373
Compare
hansl
approved these changes
Feb 9, 2017
alxhub
force-pushed
the
sw-support
branch
2 times, most recently
from
66f7bbc to
694bf59
Compare
Adds the flag 'serviceWorker' to angular-cli.json that enables support for @angular/service-worker. When this flag is true, production builds will be set up with a service worker. A ngsw-manifest.json file will be generated (or augmented) in the dist/ root, and the service worker script will be copied there. A short script will be added to index.html to register the service worker. @angular/service-worker is a dependency of @angular/cli, but not of generated projects. It is desirable for users to be able to update the version of @angular/service-worker used in their apps independently of the CLI version. Thus, the CLI will error if serviceWorker=true but @angular/service-worker is not installed in the application's node_modules, as it pulls all the service worker scripts from there. If the flag is false the effect on the CLI is minimal - the webpack plugins associated with the SW are not even require()'d.
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
Adds the flag 'serviceWorker' to angular-cli.json that enables support for @angular/service-worker. When this flag is true, production builds will be set up with a service worker. A ngsw-manifest.json file will be generated (or augmented) in the dist/ root, and the service worker script will be copied there. A short script will be added to index.html to register the service worker. @angular/service-worker is a dependency of @angular/cli, but not of generated projects. It is desirable for users to be able to update the version of @angular/service-worker used in their apps independently of the CLI version. Thus, the CLI will error if serviceWorker=true but @angular/service-worker is not installed in the application's node_modules, as it pulls all the service worker scripts from there. If the flag is false the effect on the CLI is minimal - the webpack plugins associated with the SW are not even require()'d. Closes angular#4544
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.