fix(@angular/cli): remove inexistent tslint override

[filipesilva]

no-unused-variable doesn't exist anymore, so these disables aren't doing anything. Also removed the unused vars.

[mhheise]

Would it make sense to add the noUnusedParameters and noUnusedLocals attributes to the generated project tsconfig.json to continue to enforce this check? The no-unused-variable rule in tslint was deprecated in favor of these typescript compiler flags.

[filipesilva]

I tried to do that and didn't actually see any errors in my IDE (VSCode). I actually don't know how that would be enforced now tbh, I just now that this is dead code atm.

[mhheise]

I can create a follow-up PR for the additional changes to the generated tsconfig.json if you would like to keep this unused-variable-checking functionality. I think that this could possibly be a breaking change, given that a lint warning would now become a compilation error.

[filipesilva]

@mhheise I'm interested to see if it's seamless or not, so I would appreciate the followup PR. On my tests it didn't break compilation so I found that odd.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}