fix(@angular/cli): Fixing duplicate aliases issue

[sumitarora]

ng —help calls validateAndRun twice once to check if callHelp function is to be triggered and once actually for command lookup and mutates the state of aliases. normalizeOption is what is mutating the aliases which is called from parseArgs from validateAndRun.

The current fix is to check for aliases in the list of aliases and only add it if it's not previously present else continue as usual.

Fixes: #4979

[filipesilva]

I'm not too sure this is the right approach, it just seems to treat the symptom.

The core issue is that we get different output between ng help new and ng new --help:

kamik@T460p MINGW64 /d/sandbox/master-project (master)
$ ng help new
ng new <options...>
  Creates a new directory and a new Angular app.
  --dry-run (Boolean) (Default: false) Run through without making any changes.
    aliases: -d, --dryRun
  --verbose (Boolean) (Default: false) Adds more details to output logging.
    aliases: -v, --verbose
// ...

kamik@T460p MINGW64 /d/sandbox/master-project (master)
$ ng new --help
ng new <options...>
  Creates a new directory and a new Angular app.
  --dry-run (Boolean) (Default: false) Run through without making any changes.
    aliases: -d, --dryRun, --dryRun
  --verbose (Boolean) (Default: false) Adds more details to output logging.
    aliases: -v, --verbose, --verbose
// ...

Why is that happening? Aren't those two essentially the same?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}