Skip to content

feat(@angular/cli): use standard stackTraceLimit#5284

Merged
filipesilva merged 2 commits into
angular:masterfrom
filipesilva:remove-infinite-stack-trace
Mar 7, 2017
Merged

feat(@angular/cli): use standard stackTraceLimit#5284
filipesilva merged 2 commits into
angular:masterfrom
filipesilva:remove-infinite-stack-trace

Conversation

@filipesilva
Copy link
Copy Markdown
Contributor

Sometime very long ago we set infinite stack traces and never took them out.

This PR sets infinite stack traces only on dev setups.

Sometime very long ago we set infinite stack traces and never took them out.

This PR sets infinite stack traces only on dev setups.
@filipesilva filipesilva requested a review from Brocco March 7, 2017 16:23
@filipesilva filipesilva merged commit 5c9c653 into angular:master Mar 7, 2017
@filipesilva filipesilva deleted the remove-infinite-stack-trace branch March 7, 2017 21:59
@hansl
Copy link
Copy Markdown
Contributor

hansl commented Mar 7, 2017

@filipesilva Why is this marked a feature?

@filipesilva
Copy link
Copy Markdown
Contributor Author

Should have marked it as a fix really, my bad.

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
Sometime very long ago we set infinite stack traces and never took them out.

This PR sets infinite stack traces only on dev setups.
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants