style(dev-infra): correct tslint failures in dev-infra directory (angular#37233)

Fixes tslint failures in dev-infra directory as the directory is now
part of the tslint enforced files.

PR Close angular#37233

Author: josephperrott

dev-infra/benchmark/component_benchmark/protractor-perf.conf.js

@@ -36,7 +36,7 @@ exports.config = {
     showColors: true,
     defaultTimeoutInterval: 90000,
     print: function(msg) {
-      console.log(msg);
+      console.info(msg);
     },
   },
   useAllAngular2AppRoots: true

dev-infra/benchmark/driver-utilities/index.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright Google Inc. All Rights Reserved.
+ * Copyright Google LLC All Rights Reserved.
  *
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license

dev-infra/pr/discover-new-conflicts/cli.ts

@@ -1,3 +1,11 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
 import {Arguments, Argv} from 'yargs';
 
 import {error} from '../../utils/console';

dev-infra/pr/merge/cli.ts

@@ -17,7 +17,7 @@ export function buildMergeCommand(yargs: Argv) {
   return yargs.help().strict().option('github-token', {
     type: 'string',
     description: 'Github token. If not set, token is retrieved from the environment variables.'
-  })
+  });
 }
 
 /** Handles the merge command. i.e. performs the merge of a specified pull request. */

dev-infra/pr/merge/config.ts

@@ -38,7 +38,7 @@ export interface MergeRemote {
   /** Name of the repository. */
   name: string;
   /** Whether SSH should be used for merging pull requests. */
-  useSsh?: boolean
+  useSsh?: boolean;
 }
 
 /**
@@ -87,15 +87,11 @@ export function loadAndValidateConfig(): {config?: MergeConfigWithRemote, errors
   const config: Partial<DevInfraMergeConfig> = getConfig();
 
   if (config.merge === undefined) {
-    return {
-      errors: ['No merge configuration found. Set the `merge` configuration.']
-    }
+    return {errors: ['No merge configuration found. Set the `merge` configuration.']};
   }
 
   if (typeof config.merge !== 'function') {
-    return {
-      errors: ['Expected merge configuration to be defined lazily through a function.']
-    }
+    return {errors: ['Expected merge configuration to be defined lazily through a function.']};
   }
 
   const mergeConfig = config.merge();

dev-infra/pr/merge/strategies/api-merge.ts

@@ -153,7 +153,7 @@ export class GithubApiMergeStrategy extends MergeStrategy {
    * strategy, we cannot start an interactive rebase because we merge using the Github API.
    * The Github API only allows modifications to PR title and body for squash merges.
    */
-  async _promptCommitMessageEdit(pullRequest: PullRequest, mergeOptions: PullsMergeParams) {
+  private async _promptCommitMessageEdit(pullRequest: PullRequest, mergeOptions: PullsMergeParams) {
     const commitMessage = await this._getDefaultSquashCommitMessage(pullRequest);
     const {result} = await prompt<{result: string}>({
       type: 'editor',

dev-infra/pr/merge/strategies/autosquash-merge.ts

@@ -1,3 +1,11 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
 import {join} from 'path';
 import {PullRequestFailure} from '../failures';
 import {PullRequest} from '../pull-request';

dev-infra/pr/merge/strategies/commit-message-filter.js

@@ -1,4 +1,11 @@
 #!/usr/bin/env node
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
 
 /**
  * Script that can be passed as commit message filter to `git filter-branch --msg-filter`.

dev-infra/ts-circular-dependencies/config.ts

@@ -20,7 +20,7 @@ export interface CircularDependenciesTestConfig {
   /** Path to the golden file that is used for checking and approving. */
   goldenFile: string;
   /** Glob that resolves source files which should be checked. */
-  glob: string
+  glob: string;
   /**
    * Optional module resolver function that can be used to resolve modules
    * to absolute file paths.

dev-infra/utils/github.ts

@@ -28,7 +28,7 @@ const graphql = unauthenticatedGraphql.defaults({
 
 /** Get a PR from github  */
 export async function getPr<PrSchema>(
-    prSchema: PrSchema, number: number, {owner, name}: GithubConfig) {
+    prSchema: PrSchema, prNumber: number, {owner, name}: GithubConfig) {
   const PR_QUERY = params(
       {
         $number: 'Int!',    // The PR number
@@ -41,7 +41,8 @@ export async function getPr<PrSchema>(
         })
       });
 
-  const result = await graphql(graphqlQuery(PR_QUERY), {number, owner, name}) as typeof PR_QUERY;
+  const result =
+      await graphql(graphqlQuery(PR_QUERY), {number: prNumber, owner, name}) as typeof PR_QUERY;
   return result.repository.pullRequest;
 }